You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/15 01:58:21 UTC
[GitHub] [cloudstack] utchoang opened a new pull request #4811: UI: Moves fetchdata() to the created()
utchoang opened a new pull request #4811:
URL: https://github.com/apache/cloudstack/pull/4811
### Description
Related #4762
This PR to move fetchData() to created() insteadof mount()
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4811: UI: Moves fetchdata() to the created()
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4811:
URL: https://github.com/apache/cloudstack/pull/4811#issuecomment-813287540
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4811 (SL-JID-88)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4811: UI: Moves fetchdata() to the created()
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4811:
URL: https://github.com/apache/cloudstack/pull/4811#issuecomment-809282010
@utchoang can you fix the conflict against latest 4.15 branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #4811: UI: Moves fetchdata() to the created()
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4811:
URL: https://github.com/apache/cloudstack/pull/4811#issuecomment-803813652
@rhtyd When the component is initialized, fetching data from the backend at `created()` will be done without having to wait for the DOM to be mounted or rendered as if it were called on `mounted()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4811: UI: Moves fetchdata() to the created()
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4811:
URL: https://github.com/apache/cloudstack/pull/4811#issuecomment-806377450
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4811 (SL-JID-63)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4811: UI: Moves fetchdata() to the created()
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4811:
URL: https://github.com/apache/cloudstack/pull/4811#issuecomment-813284982
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4811: UI: Moves fetchdata() to the created()
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4811:
URL: https://github.com/apache/cloudstack/pull/4811#issuecomment-799164872
@utchoang will this offer any performance improvement? I hope we are not accessing/manipulating DOM elements in any of the fetchData methods
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4811: UI: Moves fetchdata() to the created()
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4811:
URL: https://github.com/apache/cloudstack/pull/4811#issuecomment-806372785
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #4811: UI: Moves fetchdata() to the created()
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4811:
URL: https://github.com/apache/cloudstack/pull/4811#issuecomment-799141800
@blueorangutan ui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #4811: UI: Moves fetchdata() to the created()
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #4811:
URL: https://github.com/apache/cloudstack/pull/4811#discussion_r600259854
##########
File path: ui/src/views/offering/ImportBackupOffering.vue
##########
@@ -128,10 +128,9 @@ export default {
this.apiParams[param.name] = param
})
},
- mounted () {
+ created () {
this.fetchData()
},
- inject: ['parentFetchData'],
Review comment:
Here too ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on a change in pull request #4811: UI: Moves fetchdata() to the created()
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #4811:
URL: https://github.com/apache/cloudstack/pull/4811#discussion_r600270167
##########
File path: ui/src/views/infra/network/EditTrafficLabel.vue
##########
@@ -143,8 +143,7 @@ export default {
})
}
},
- inject: ['parentFetchData'],
Review comment:
@davidjumani No, delete as it is not used in this component.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4811: UI: Moves fetchdata() to the created()
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4811:
URL: https://github.com/apache/cloudstack/pull/4811#issuecomment-806373121
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4811: UI: Moves fetchdata() to the created()
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4811:
URL: https://github.com/apache/cloudstack/pull/4811#issuecomment-813285136
@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4811: UI: Moves fetchdata() to the created()
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4811:
URL: https://github.com/apache/cloudstack/pull/4811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4811: UI: Moves fetchdata() to the created()
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4811:
URL: https://github.com/apache/cloudstack/pull/4811#issuecomment-803807053
@utchoang what are the pros and cons of using one vs the other?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4811: UI: Moves fetchdata() to the created()
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4811:
URL: https://github.com/apache/cloudstack/pull/4811#issuecomment-799142139
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #4811: UI: Moves fetchdata() to the created()
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #4811:
URL: https://github.com/apache/cloudstack/pull/4811#discussion_r600255533
##########
File path: ui/src/views/infra/network/EditTrafficLabel.vue
##########
@@ -143,8 +143,7 @@ export default {
})
}
},
- inject: ['parentFetchData'],
Review comment:
@utchoang Removed by accident ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #4811: UI: Moves fetchdata() to the created()
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4811:
URL: https://github.com/apache/cloudstack/pull/4811#issuecomment-799176882
@shwstppr Yes. In https://github.com/apache/cloudstack-primate/issues/719 then move fetchData to created from mounted to reduce wait time for API calls since the data has been created but the page has not yet been rendered
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #4811: UI: Moves fetchdata() to the created()
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #4811:
URL: https://github.com/apache/cloudstack/pull/4811#discussion_r600273670
##########
File path: ui/src/views/infra/network/EditTrafficLabel.vue
##########
@@ -143,8 +143,7 @@ export default {
})
}
},
- inject: ['parentFetchData'],
Review comment:
Line 198 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on a change in pull request #4811: UI: Moves fetchdata() to the created()
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #4811:
URL: https://github.com/apache/cloudstack/pull/4811#discussion_r600291558
##########
File path: ui/src/views/infra/network/EditTrafficLabel.vue
##########
@@ -143,8 +143,7 @@ export default {
})
}
},
- inject: ['parentFetchData'],
Review comment:
Ah. Maybe I am confused with the PR async job. I'll fix it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4811: UI: Moves fetchdata() to the created()
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4811:
URL: https://github.com/apache/cloudstack/pull/4811#issuecomment-811694322
@utchoang can you fix the conflict?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org