You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Adam B (JIRA)" <ji...@apache.org> on 2014/11/07 11:46:33 UTC
[jira] [Updated] (MESOS-1686) URI query strings are preserved in
local filename
[ https://issues.apache.org/jira/browse/MESOS-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam B updated MESOS-1686:
--------------------------
Component/s: fetcher
> URI query strings are preserved in local filename
> -------------------------------------------------
>
> Key: MESOS-1686
> URL: https://issues.apache.org/jira/browse/MESOS-1686
> Project: Mesos
> Issue Type: Bug
> Components: fetcher
> Affects Versions: 0.20.0, 0.19.1
> Reporter: Mike Babineau
> Priority: Minor
> Labels: newbie
>
> When launching a task that includes a URI, the resulting local filename includes the query string. I assume this is undesired.
> Example:
> {{http://builds.mycompany.com/myapp.jar?auth_token=abc123}}
> is saved to
> {{myapp.jar?auth_token=abc123}}
> It appears the problem is that {{launcher/fetcher.cpp}} generates the local filename with {{os::basename(uri)}}. While keeping everything right of the last "/" is appropriate for basenames of local paths, URIs should be handled differently.
> Given the structure:
> {{scheme://domain:port/path?query_string#fragment_id}}
> we can probably get by with a function that returns {{basename(uri.path)}}
> Not sure if that should live in the stout package or somewhere else. Happy to submit a patch if someone can tell me where to put the function.
> Thanks in advance!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)