[GitHub] [hive] sankarh commented on a change in pull request #667: HIVE-21844 : HMS schema Upgrade Script is failing with NPE

[GitBox <gi...@apache.org>]

sankarh commented on a change in pull request #667: HIVE-21844 : HMS schema Upgrade Script is failing with NPE
URL: https://github.com/apache/hive/pull/667#discussion_r291881418
 
 

 ##########
 File path: beeline/src/java/org/apache/hive/beeline/TableOutputFormat.java
 ##########
 @@ -116,6 +116,10 @@ ColorBuffer getOutputString(Rows rows, Rows.Row row, String delim) {
       if (buf.getVisibleLength() > 0) {
         buf.green(delim);
       }
+ 
+      if (row.values[i] == null) {
 
 Review comment:
   In apache/master, we have "SELECT 'Upgrading MetaStore schema from 2.1.0 to 2.2.0' AS MESSAGE;" which shouldn't have the issue as per description in jira.
   I think, skipping the row based on null values is incorrect as it may have any other side effect.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org