You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-commits@hadoop.apache.org by cn...@apache.org on 2013/06/27 00:33:25 UTC
svn commit: r1497146 - in
/hadoop/common/branches/branch-2.1-beta/hadoop-hdfs-project/hadoop-hdfs:
CHANGES.txt
src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
Author: cnauroth
Date: Wed Jun 26 22:33:24 2013
New Revision: 1497146
URL: http://svn.apache.org/r1497146
Log:
HDFS-4932. Merging change r1497143 from branch-2 to branch-2.1-beta.
Modified:
hadoop/common/branches/branch-2.1-beta/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
hadoop/common/branches/branch-2.1-beta/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
Modified: hadoop/common/branches/branch-2.1-beta/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-2.1-beta/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt?rev=1497146&r1=1497145&r2=1497146&view=diff
==============================================================================
--- hadoop/common/branches/branch-2.1-beta/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt (original)
+++ hadoop/common/branches/branch-2.1-beta/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt Wed Jun 26 22:33:24 2013
@@ -172,6 +172,9 @@ Release 2.1.0-beta - 2013-07-02
HDFS-4772. Add number of children in HdfsFileStatus. (brandonli)
+ HDFS-4932. Avoid a wide line on the name node webUI if we have more Journal
+ nodes. (Fengdong Yu via cnauroth)
+
OPTIMIZATIONS
BUG FIXES
Modified: hadoop/common/branches/branch-2.1-beta/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-2.1-beta/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java?rev=1497146&r1=1497145&r2=1497146&view=diff
==============================================================================
--- hadoop/common/branches/branch-2.1-beta/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java (original)
+++ hadoop/common/branches/branch-2.1-beta/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java Wed Jun 26 22:33:24 2013
@@ -249,9 +249,30 @@ class NamenodeJspHelper {
+ "<thead><tr><td><b>Journal Manager</b></td><td><b>State</b></td></tr></thead>");
for (JournalAndStream jas : log.getJournals()) {
out.print("<tr>");
- out.print("<td>" + jas.getManager());
- if (jas.isRequired()) {
- out.print(" [required]");
+ out.print("<td>");
+
+ /**
+ * Insert a line break every 3 journal nodes to avoid a very wide line.
+ */
+ JournalManager manager = jas.getManager();
+ if (null != manager) {
+ String[] managers = manager.toString().split(",");
+
+ for (int i = 0; i < managers.length; ++i) {
+ out.print(managers[i]);
+
+ if (i < managers.length - 1) {
+ out.print(",");
+ }
+
+ if ((i+1) % 3 == 0) {
+ out.print("<br/>");
+ }
+ }
+
+ if (jas.isRequired()) {
+ out.print(" [required]");
+ }
}
out.print("</td><td>");