[jira] Commented: (IVYDE-176) Refresh action is detaching javadoc and sources

["Nicolas Lalevée (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IVYDE-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702428#action_12702428 ] 

Nicolas Lalevée commented on IVYDE-176:
---------------------------------------

I have reproduced the bug.

I have not tested your patch, but it seems it tries to download the artifact which have the extra attributes m:classifier=sources.
First it seems to me wrong to try to download something which doing a simple refresh, you should only try with the data in cache. And then this solution would only work on mavenish module descriptor due to the extra attribute.

Looking closer to the code, I think it fails beacuse in the IvyResolveJob, when it tries to parse the resolve report, it doesn't fill the 'artifactsByDependency' map. So we should better use the ivy api to get from the cache the info to populate that map.

> Refresh action is detaching javadoc and sources
> -----------------------------------------------
>
>                 Key: IVYDE-176
>                 URL: https://issues.apache.org/jira/browse/IVYDE-176
>             Project: IvyDE
>          Issue Type: Bug
>         Environment: linux eclipse 3.4.2 sr2 x64
>            Reporter: Daniel Becheanu
>             Fix For: 2.0.0.final
>
>         Attachments: IVYDE-176_patch.txt
>
>
> If you do refresh after a successful resolve (properly get sources/javadocs for your artifacts) the sources/javadocs are removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.