You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "chouchouji (via GitHub)" <gi...@apache.org> on 2024/09/18 03:38:07 UTC
[PR] [AMORO-3139] Improve list content of optimizing page [amoro]
chouchouji opened a new pull request, #3201:
URL: https://github.com/apache/amoro/pull/3201
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://amoro.apache.org/how-to-contribute/
2. If the PR is related to an issue in https://github.com/apache/amoro/issues, add '[AMORO-XXXX]' in your PR title, e.g., '[AMORO-XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][AMORO-XXXX] Your PR title ...'.
-->
## Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about its use case.
2. If you fix a bug, you can clarify why it is a bug.
3. Use Fix/Resolve/Close #{ISSUE_NUMBER} to link this PR to its related issue
-->
Link issue #3139.
## Brief change log
<!--
Clearly describe the changes made in modules, classes, methods, etc.
-->
-
## How was this patch tested?
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] Run test locally before making a pull request
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3139] Improve list content of optimizing page [amoro]
Posted by "majin1102 (via GitHub)" <gi...@apache.org>.
majin1102 commented on code in PR #3201:
URL: https://github.com/apache/amoro/pull/3201#discussion_r1796883825
##########
amoro-web/mock/modules/optimize.js:
##########
@@ -37,6 +37,15 @@ export default [
result: ['container1', 'container2']
}),
},
+ {
+ url: '/mock/ams/v1/optimize/action',
Review Comment:
I think /actions here is better, I have updated the issues.
WDYT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3139] Improve list content of optimizing page [amoro]
Posted by "majin1102 (via GitHub)" <gi...@apache.org>.
majin1102 merged PR #3201:
URL: https://github.com/apache/amoro/pull/3201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3139] Improve list content of optimizing page [amoro]
Posted by "chouchouji (via GitHub)" <gi...@apache.org>.
chouchouji commented on code in PR #3201:
URL: https://github.com/apache/amoro/pull/3201#discussion_r1797613128
##########
amoro-web/src/services/optimize.service.ts:
##########
@@ -22,17 +22,23 @@ export function getOptimizerGroups() {
return request.get('ams/v1/optimize/optimizerGroups')
}
+export function getOptimizerAction() {
+ return request.get('/ams/v1/optimize/action')
+}
+
export function getOptimizerTableList(
params: {
optimizerGroup: string
dbSearchInput: string
tableSearchInput: string
page: number
pageSize: number
+ action: string[]
+ sortField: string
Review Comment:
If we don't need sortOrder now, I will delete it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3139] Improve list content of optimizing page [amoro]
Posted by "majin1102 (via GitHub)" <gi...@apache.org>.
majin1102 commented on code in PR #3201:
URL: https://github.com/apache/amoro/pull/3201#discussion_r1796863822
##########
amoro-web/src/services/optimize.service.ts:
##########
@@ -22,17 +22,23 @@ export function getOptimizerGroups() {
return request.get('ams/v1/optimize/optimizerGroups')
}
+export function getOptimizerAction() {
+ return request.get('/ams/v1/optimize/action')
+}
+
export function getOptimizerTableList(
params: {
optimizerGroup: string
dbSearchInput: string
tableSearchInput: string
page: number
pageSize: number
+ action: string[]
+ sortField: string
Review Comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3139] Improve list content of optimizing page [amoro]
Posted by "majin1102 (via GitHub)" <gi...@apache.org>.
majin1102 commented on code in PR #3201:
URL: https://github.com/apache/amoro/pull/3201#discussion_r1796863822
##########
amoro-web/src/services/optimize.service.ts:
##########
@@ -22,17 +22,23 @@ export function getOptimizerGroups() {
return request.get('ams/v1/optimize/optimizerGroups')
}
+export function getOptimizerAction() {
+ return request.get('/ams/v1/optimize/action')
+}
+
export function getOptimizerTableList(
params: {
optimizerGroup: string
dbSearchInput: string
tableSearchInput: string
page: number
pageSize: number
+ action: string[]
+ sortField: string
Review Comment:
yes, or you could add a sortOrder to mark 'asend' or 'descend'?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3139] Improve list content of optimizing page [amoro]
Posted by "majin1102 (via GitHub)" <gi...@apache.org>.
majin1102 commented on code in PR #3201:
URL: https://github.com/apache/amoro/pull/3201#discussion_r1796864804
##########
amoro-web/src/utils/table.ts:
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/**
+ * Calculate table max width
+ */
+export function getTableMaxWidth(columns: Array<{ width: number }>) {
Review Comment:
excellent!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3139] Improve list content of optimizing page [amoro]
Posted by "chouchouji (via GitHub)" <gi...@apache.org>.
chouchouji commented on code in PR #3201:
URL: https://github.com/apache/amoro/pull/3201#discussion_r1797612949
##########
amoro-web/mock/modules/optimize.js:
##########
@@ -37,6 +37,15 @@ export default [
result: ['container1', 'container2']
}),
},
+ {
+ url: '/mock/ams/v1/optimize/action',
Review Comment:
ok, i get it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org