You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/04/22 04:51:57 UTC
[GitHub] [incubator-hudi] dengziming opened a new pull request #1547: [MINOR]: Fix annotations in HoodieDeltaStreamer
dengziming opened a new pull request #1547:
URL: https://github.com/apache/incubator-hudi/pull/1547
we use `--props` rather than `--propsFilePath` to set property file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] pratyakshsharma commented on issue #1547: [MINOR]: Fix annotations in HoodieDeltaStreamer
Posted by GitBox <gi...@apache.org>.
pratyakshsharma commented on issue #1547:
URL: https://github.com/apache/incubator-hudi/pull/1547#issuecomment-617745980
LGTM. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] dengziming commented on a change in pull request #1547: [MINOR]: Fix annotations in HoodieDeltaStreamer
Posted by GitBox <gi...@apache.org>.
dengziming commented on a change in pull request #1547:
URL: https://github.com/apache/incubator-hudi/pull/1547#discussion_r412932116
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -185,7 +185,7 @@ public Operation convert(String value) throws ParameterException {
"file://" + System.getProperty("user.dir") + "/src/test/resources/delta-streamer-config/dfs-source.properties";
@Parameter(names = {"--hoodie-conf"}, description = "Any configuration that can be set in the properties file "
- + "(using the CLI parameter \"--propsFilePath\") can also be passed command line using this parameter")
Review comment:
thank you for your reminding, done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] pratyakshsharma commented on a change in pull request #1547: [MINOR]: Fix annotations in HoodieDeltaStreamer
Posted by GitBox <gi...@apache.org>.
pratyakshsharma commented on a change in pull request #1547:
URL: https://github.com/apache/incubator-hudi/pull/1547#discussion_r412919212
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -185,7 +185,7 @@ public Operation convert(String value) throws ParameterException {
"file://" + System.getProperty("user.dir") + "/src/test/resources/delta-streamer-config/dfs-source.properties";
@Parameter(names = {"--hoodie-conf"}, description = "Any configuration that can be set in the properties file "
- + "(using the CLI parameter \"--propsFilePath\") can also be passed command line using this parameter")
Review comment:
can you make this change in HoodieMultiTableDeltaStreamer as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org