You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by rhauch <gi...@git.apache.org> on 2017/09/28 23:42:48 UTC
[GitHub] kafka pull request #3987: KAFKA-5990: Enable generation of metrics docs for ...
GitHub user rhauch opened a pull request:
https://github.com/apache/kafka/pull/3987
KAFKA-5990: Enable generation of metrics docs for Connect
A new mechanism was added recently to the Metrics framework to make it easier to generate the documentation. It uses a registry with a MetricsNameTemplate for each metric, and then those templates are used when creating the actual metrics. The metrics framework provides utilities that can generate the HTML documentation from the registry of templates.
This change moves the recently-added Connect metrics over to use these templates and to then generate the metric documentation for Connect.
This PR is based upon #3975 and can be rebased once that has been merged.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rhauch/kafka kafka-5990
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3987.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3987
----
commit 23aebcdf7797923865a771e7acac89e7e2572e3d
Author: Randall Hauch <rh...@gmail.com>
Date: 2017-09-26T15:28:12Z
KAFKA-5902 Added sink task metrics
commit 9824e329ef599c59ea4e7f60cf46ec907b516d90
Author: Randall Hauch <rh...@gmail.com>
Date: 2017-09-28T20:47:39Z
KAFKA-5902 Changed to measuring task processing lag behind consumer
Changed the `sink-record-lag-max` metric to be the maximum lag in terms of number of records that the sink task is behind the consumer's position for any topic partitions. This is not ideal, since often “lag” is defined to represent how far behind the task (or consumer) is relative to the end of the topic partition. However, the most recent offset for the topic partition is not easy to access in Connect.
commit d38dbde9f72926c68383729f9c80513879913cde
Author: Randall Hauch <rh...@gmail.com>
Date: 2017-09-28T19:12:21Z
KAFKA-5990 Enable generation of metrics docs for Connect
A new mechanism was added recently to the Metrics framework to make it easier to generate the documentation. It uses a registry with a MetricsNameTemplate for each metric, and then those templates are used when creating the actual metrics. The metrics framework provides utilities that can generate the HTML documentation from the registry of templates.
This change moves the recently-added Connect metrics over to use these templates and to then generate the metric documentation for Connect.
----
---
[GitHub] kafka pull request #3987: KAFKA-5990: Enable generation of metrics docs for ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/3987
---