You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by masaki-yamakawa <gi...@git.apache.org> on 2017/05/24 10:02:45 UTC
[GitHub] geode pull request #530: GEODE-2981: Fix the line feed code of the test expe...
GitHub user masaki-yamakawa opened a pull request:
https://github.com/apache/geode/pull/530
GEODE-2981: Fix the line feed code of the test expected value
Fixed the line feed code of the test expectation value so that it does not depend on the runtime environment.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [X] Is your initial contribution a single, squashed commit?
- [X] Does `gradlew build` run cleanly?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/masaki-yamakawa/geode feature/GEODE-2981
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/530.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #530
----
commit a93abb4c7761a1795bef9e4e411fd0f3a5905302
Author: masaki.yamakawa <ma...@ulsystems.co.jp>
Date: 2017-05-24T09:29:46Z
GEODE-2981: Fix the line feed code of the test expected value
Fixed the line feed code of the test expectation value so that it does
not depend on the runtime environment.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #530: GEODE-2981: Fix the line feed code of the test expected va...
Posted by jinmeiliao <gi...@git.apache.org>.
Github user jinmeiliao commented on the issue:
https://github.com/apache/geode/pull/530
will pull this in after testing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #530: GEODE-2981: Fix the line feed code of the test expe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/530
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #530: GEODE-2981: Fix the line feed code of the test expected va...
Posted by jaredjstewart <gi...@git.apache.org>.
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/530
Thank you for your contribution, looks good to me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---