You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/16 02:11:44 UTC
[GitHub] [spark] javierivanov opened a new pull request #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
javierivanov opened a new pull request #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR introduces a change to false for the insideComment flag on a newline. Fixing the issue introduced by SPARK-30049.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Previously on SPARK-30049 a comment containing an unclosed quote produced the following issue:
```
spark-sql> SELECT 1 -- someone's comment here
> ;
Error in query:
extraneous input ';' expecting <EOF>(line 2, pos 0)
== SQL ==
SELECT 1 -- someone's comment here
;
^^^
```
This was caused because there was no flag for comment sections inside the splitSemiColon method to ignore quotes. SPARK-30049 added that flag and fixed the issue, but introduced the follwoing problem:
```
spark-sql> select
> 1,
> -- two
> 2;
Error in query:
mismatched input '<EOF>' expecting {'(', 'ADD', 'AFTER', 'ALL', 'ALTER', ...}(line 3, pos 2)
== SQL ==
select
1,
--^^^
```
This issue is generated by a missing turn-off for the insideComment flag with a newline.
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Previous tests using line-continuity(`\`) were removed and a test for inline comments within a query was added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-599307680
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#discussion_r407348439
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala
##########
@@ -454,24 +454,24 @@ class CliSuite extends SparkFunSuite with BeforeAndAfterAll with BeforeAndAfterE
}
test("SPARK-30049 Should not complain for quotes in commented lines") {
- runCliWithin(1.minute)(
+ runCliWithin(3.minute)(
"""SELECT concat('test', 'comment') -- someone's comment here
|;""".stripMargin -> "testcomment"
)
+ runCliWithin(3.minute)(
+ """SELECT concat('test', 'comment'),
+ | -- someone's comment here
+ | 2;""".stripMargin -> "testcomment"
+ )
Review comment:
Could you move this test into a new test unit just like `test("SPARK-31102: XXXX") {...}`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612907346
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121181/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-613406609
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121260/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612785024
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612944058
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121211/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-599326425
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119825/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#discussion_r407348488
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala
##########
@@ -454,24 +454,24 @@ class CliSuite extends SparkFunSuite with BeforeAndAfterAll with BeforeAndAfterE
}
test("SPARK-30049 Should not complain for quotes in commented lines") {
- runCliWithin(1.minute)(
+ runCliWithin(3.minute)(
Review comment:
Why did we need this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-613180970
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-613267578
**[Test build #121260 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121260/testReport)** for PR 27920 at commit [`0571f21`](https://github.com/apache/spark/commit/0571f21a0c058e0e1c14efd54e174d64f9420b01).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] javierivanov commented on a change in pull request #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
javierivanov commented on a change in pull request #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#discussion_r407301502
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala
##########
@@ -402,24 +402,14 @@ class CliSuite extends SparkFunSuite with BeforeAndAfterAll with Logging {
}
test("SPARK-30049 Should not complain for quotes in commented lines") {
- runCliWithin(1.minute)(
+ runCliWithin(3.minute)(
"""SELECT concat('test', 'comment') -- someone's comment here
|;""".stripMargin -> "testcomment"
)
- }
-
- test("SPARK-30049 Should not complain for quotes in commented with multi-lines") {
- runCliWithin(1.minute)(
- """SELECT concat('test', 'comment') -- someone's comment here \\
- | comment continues here with single ' quote \\
- | extra ' \\
- |;""".stripMargin -> "testcomment"
- )
- runCliWithin(1.minute)(
- """SELECT concat('test', 'comment') -- someone's comment here \\
- | comment continues here with single ' quote \\
- | extra ' \\
- | ;""".stripMargin -> "testcomment"
Review comment:
@maropu I have added the fix. Let me know what you think :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#discussion_r393456400
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala
##########
@@ -402,24 +402,14 @@ class CliSuite extends SparkFunSuite with BeforeAndAfterAll with Logging {
}
test("SPARK-30049 Should not complain for quotes in commented lines") {
- runCliWithin(1.minute)(
+ runCliWithin(3.minute)(
"""SELECT concat('test', 'comment') -- someone's comment here
|;""".stripMargin -> "testcomment"
)
- }
-
- test("SPARK-30049 Should not complain for quotes in commented with multi-lines") {
- runCliWithin(1.minute)(
- """SELECT concat('test', 'comment') -- someone's comment here \\
- | comment continues here with single ' quote \\
- | extra ' \\
- |;""".stripMargin -> "testcomment"
- )
- runCliWithin(1.minute)(
- """SELECT concat('test', 'comment') -- someone's comment here \\
- | comment continues here with single ' quote \\
- | extra ' \\
- | ;""".stripMargin -> "testcomment"
Review comment:
If we can, the fix in `SqlBase.g4` (`SIMPLE_COMENT`) looks fine to me and I think the queries above should work in Spark SQL: https://github.com/apache/spark/blob/master/sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4#L1811 Could you try?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-613264402
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612726536
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25849/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-611397042
@javierivanov Any update?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-613180970
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612785024
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-613264411
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121243/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-613264402
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612907339
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612784597
**[Test build #121181 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121181/testReport)** for PR 27920 at commit [`440dcbd`](https://github.com/apache/spark/commit/440dcbd93986b82e36d911ee0461aab3b4927f8c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-599307680
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612726536
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25849/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-599307401
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612907339
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612781455
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612944049
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-613405762
**[Test build #121260 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121260/testReport)** for PR 27920 at commit [`0571f21`](https://github.com/apache/spark/commit/0571f21a0c058e0e1c14efd54e174d64f9420b01).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612906439
**[Test build #121181 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121181/testReport)** for PR 27920 at commit [`440dcbd`](https://github.com/apache/spark/commit/440dcbd93986b82e36d911ee0461aab3b4927f8c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-599314095
**[Test build #119825 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119825/testReport)** for PR 27920 at commit [`d69d271`](https://github.com/apache/spark/commit/d69d27126c06ea9782c5422a5435809a062b8ed7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-613180671
**[Test build #121243 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121243/testReport)** for PR 27920 at commit [`0571f21`](https://github.com/apache/spark/commit/0571f21a0c058e0e1c14efd54e174d64f9420b01).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612785026
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25868/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612907346
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121181/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#discussion_r407348128
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala
##########
@@ -454,24 +454,24 @@ class CliSuite extends SparkFunSuite with BeforeAndAfterAll with BeforeAndAfterE
}
test("SPARK-30049 Should not complain for quotes in commented lines") {
- runCliWithin(1.minute)(
+ runCliWithin(3.minute)(
"""SELECT concat('test', 'comment') -- someone's comment here
|;""".stripMargin -> "testcomment"
)
+ runCliWithin(3.minute)(
+ """SELECT concat('test', 'comment'),
+ | -- someone's comment here
+ | 2;""".stripMargin -> "testcomment"
+ )
}
test("SPARK-30049 Should not complain for quotes in commented with multi-lines") {
- runCliWithin(1.minute)(
- """SELECT concat('test', 'comment') -- someone's comment here \\
- | comment continues here with single ' quote \\
- | extra ' \\
+ runCliWithin(3.minute)(
+ """SELECT concat('test', 'comment') -- someone's comment here \
+ | comment continues here with single ' quote \
+ | extra ' \
|;""".stripMargin -> "testcomment"
)
- runCliWithin(1.minute)(
- """SELECT concat('test', 'comment') -- someone's comment here \\
- | comment continues here with single ' quote \\
- | extra ' \\
- | ;""".stripMargin -> "testcomment"
- )
}
+
Review comment:
nit: unnecessary change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612889303
**[Test build #121211 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121211/testReport)** for PR 27920 at commit [`0571f21`](https://github.com/apache/spark/commit/0571f21a0c058e0e1c14efd54e174d64f9420b01).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612944049
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-613180671
**[Test build #121243 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121243/testReport)** for PR 27920 at commit [`0571f21`](https://github.com/apache/spark/commit/0571f21a0c058e0e1c14efd54e174d64f9420b01).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612889762
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25899/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612944058
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121211/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-613264411
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121243/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-613406609
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121260/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612726340
**[Test build #121162 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121162/testReport)** for PR 27920 at commit [`440dcbd`](https://github.com/apache/spark/commit/440dcbd93986b82e36d911ee0461aab3b4927f8c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-599314402
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612889303
**[Test build #121211 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121211/testReport)** for PR 27920 at commit [`0571f21`](https://github.com/apache/spark/commit/0571f21a0c058e0e1c14efd54e174d64f9420b01).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-613180978
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25930/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612889751
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-613179247
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-599314402
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-599326419
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612781461
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121162/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-613406598
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-599307401
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-613268192
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-599326419
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#discussion_r393456400
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala
##########
@@ -402,24 +402,14 @@ class CliSuite extends SparkFunSuite with BeforeAndAfterAll with Logging {
}
test("SPARK-30049 Should not complain for quotes in commented lines") {
- runCliWithin(1.minute)(
+ runCliWithin(3.minute)(
"""SELECT concat('test', 'comment') -- someone's comment here
|;""".stripMargin -> "testcomment"
)
- }
-
- test("SPARK-30049 Should not complain for quotes in commented with multi-lines") {
- runCliWithin(1.minute)(
- """SELECT concat('test', 'comment') -- someone's comment here \\
- | comment continues here with single ' quote \\
- | extra ' \\
- |;""".stripMargin -> "testcomment"
- )
- runCliWithin(1.minute)(
- """SELECT concat('test', 'comment') -- someone's comment here \\
- | comment continues here with single ' quote \\
- | extra ' \\
- | ;""".stripMargin -> "testcomment"
Review comment:
If we can, the fix in `SqlBase.g4` (`SIMPLE_COMENT`) looks fine to me: https://github.com/apache/spark/blob/master/sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4#L1811 Could you try?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612726535
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-599314095
**[Test build #119825 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119825/testReport)** for PR 27920 at commit [`d69d271`](https://github.com/apache/spark/commit/d69d27126c06ea9782c5422a5435809a062b8ed7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-613180978
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25930/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612784597
**[Test build #121181 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121181/testReport)** for PR 27920 at commit [`440dcbd`](https://github.com/apache/spark/commit/440dcbd93986b82e36d911ee0461aab3b4927f8c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-599344938
cc: @wangyum
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] javierivanov commented on a change in pull request #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
javierivanov commented on a change in pull request #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#discussion_r393070691
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala
##########
@@ -402,24 +402,14 @@ class CliSuite extends SparkFunSuite with BeforeAndAfterAll with Logging {
}
test("SPARK-30049 Should not complain for quotes in commented lines") {
- runCliWithin(1.minute)(
+ runCliWithin(3.minute)(
"""SELECT concat('test', 'comment') -- someone's comment here
|;""".stripMargin -> "testcomment"
)
- }
-
- test("SPARK-30049 Should not complain for quotes in commented with multi-lines") {
- runCliWithin(1.minute)(
- """SELECT concat('test', 'comment') -- someone's comment here \\
- | comment continues here with single ' quote \\
- | extra ' \\
- |;""".stripMargin -> "testcomment"
- )
- runCliWithin(1.minute)(
- """SELECT concat('test', 'comment') -- someone's comment here \\
- | comment continues here with single ' quote \\
- | extra ' \\
- | ;""".stripMargin -> "testcomment"
Review comment:
Hey @maropu !
The SQL parser does not recognize line-continuity per se.
```
scala> sql(s"""SELECT concat('test', 'comment') -- someone's comment here \\\ncomment continues here with single ' quote \\\nextra ' \\""")
org.apache.spark.sql.catalyst.parser.ParseException:
mismatched input 'continues' expecting {<EOF>, ',', 'CLUSTER', 'DISTRIBUTE', 'EXCEPT', 'FROM', 'GROUP', 'HAVING', 'INTERSECT', 'LATERAL', 'LIMIT', 'ORDER', 'MINUS', 'SORT', 'UNION', 'WHERE', 'WINDOW', '-'}(line 2, pos 8)
== SQL ==
SELECT concat('test', 'comment') -- someone's comment here \
comment continues here with single ' quote \
--------^^^
extra ' \
```
It works just fine for inline comments included backslash:
```
scala> sql(s"""SELECT concat('test', 'comment') -- someone's comment here \\\n,2""") show
+---------------------+---+
|concat(test, comment)| 2|
+---------------------+---+
| testcomment| 2|
+---------------------+---+
```
But does not work outside the inline comment(the backslash):
```
sql(s"""SELECT concat('test', 'comment') -- someone's comment here \n,2\\\n""")
org.apache.spark.sql.catalyst.parser.ParseException:
extraneous input '\' expecting <EOF>(line 2, pos 2)
== SQL ==
SELECT concat('test', 'comment') -- someone's comment here
,2\
--^^^
```
Previously worked fine because of this very bug, the insideComment flag ignored everything until the end of the string. But the spark SQL parser does not recognize the backslashes. Line-continuity can be added to the CLI. But I think that feature should be added directly to the SQL parser to avoid confusion.
Let me know your thoughts 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#discussion_r407349410
##########
File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -1814,7 +1814,7 @@ fragment LETTER
;
SIMPLE_COMMENT
- : '--' ~[\r\n]* '\r'? '\n'? -> channel(HIDDEN)
+ : '--' ('\\\n' | ~[\r\n])* '\r'? '\n'? -> channel(HIDDEN)
Review comment:
Please add tests in `PlanParserSuite`, too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612782947
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612781191
**[Test build #121162 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121162/testReport)** for PR 27920 at commit [`440dcbd`](https://github.com/apache/spark/commit/440dcbd93986b82e36d911ee0461aab3b4927f8c).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612889751
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-599326425
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119825/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-613180755
Could you check this? @wangyum
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-599312972
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-599326321
**[Test build #119825 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119825/testReport)** for PR 27920 at commit [`d69d271`](https://github.com/apache/spark/commit/d69d27126c06ea9782c5422a5435809a062b8ed7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] javierivanov commented on a change in pull request #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
javierivanov commented on a change in pull request #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#discussion_r407466678
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala
##########
@@ -454,24 +454,24 @@ class CliSuite extends SparkFunSuite with BeforeAndAfterAll with BeforeAndAfterE
}
test("SPARK-30049 Should not complain for quotes in commented lines") {
- runCliWithin(1.minute)(
+ runCliWithin(3.minute)(
Review comment:
I got timeouts running in a slow machine, changing back to 1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612781455
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-613406598
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-613268192
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-613267578
**[Test build #121260 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121260/testReport)** for PR 27920 at commit [`0571f21`](https://github.com/apache/spark/commit/0571f21a0c058e0e1c14efd54e174d64f9420b01).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#discussion_r392782401
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala
##########
@@ -402,24 +402,14 @@ class CliSuite extends SparkFunSuite with BeforeAndAfterAll with Logging {
}
test("SPARK-30049 Should not complain for quotes in commented lines") {
- runCliWithin(1.minute)(
+ runCliWithin(3.minute)(
"""SELECT concat('test', 'comment') -- someone's comment here
|;""".stripMargin -> "testcomment"
)
- }
-
- test("SPARK-30049 Should not complain for quotes in commented with multi-lines") {
- runCliWithin(1.minute)(
- """SELECT concat('test', 'comment') -- someone's comment here \\
- | comment continues here with single ' quote \\
- | extra ' \\
- |;""".stripMargin -> "testcomment"
- )
- runCliWithin(1.minute)(
- """SELECT concat('test', 'comment') -- someone's comment here \\
- | comment continues here with single ' quote \\
- | extra ' \\
- | ;""".stripMargin -> "testcomment"
Review comment:
Why you did you remove the existing tests instead of adding new tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-613268199
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25947/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612726535
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-599314405
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24555/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-613268199
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25947/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612781461
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121162/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-599314405
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24555/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-613263783
**[Test build #121243 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121243/testReport)** for PR 27920 at commit [`0571f21`](https://github.com/apache/spark/commit/0571f21a0c058e0e1c14efd54e174d64f9420b01).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] javierivanov commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
javierivanov commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-611557221
@maropu I am extremly sorry, I will commit soon :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-613266767
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612726340
**[Test build #121162 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121162/testReport)** for PR 27920 at commit [`440dcbd`](https://github.com/apache/spark/commit/440dcbd93986b82e36d911ee0461aab3b4927f8c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27920: [SPARK-31102][SQL]
Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612943859
**[Test build #121211 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121211/testReport)** for PR 27920 at commit [`0571f21`](https://github.com/apache/spark/commit/0571f21a0c058e0e1c14efd54e174d64f9420b01).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612889762
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25899/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27920:
[SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27920: [SPARK-31102][SQL] Spark-sql fails to parse when contains comment.
URL: https://github.com/apache/spark/pull/27920#issuecomment-612785026
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25868/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org