You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Julian Hyde (JIRA)" <ji...@apache.org> on 2017/03/21 18:02:42 UTC

[jira] [Comment Edited] (CALCITE-455) User-defined functions should be able to use custom java arguments

    [ https://issues.apache.org/jira/browse/CALCITE-455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14200581#comment-14200581 ] 

Julian Hyde edited comment on CALCITE-455 at 3/21/17 6:02 PM:
--------------------------------------------------------------

{{MyUnWrapFunction}} with {{Object}} argument works properly.
I guess the problem might be somewhere in [OptiqCatalogReader.toSql|https://github.com/apache/calcite/tree/8e480759fc25d7a1e10f7f20f9eddc7556beded8/core/src/main/java/net/hydromatic/optiq/prepare/OptiqCatalogReader.java#L248]


was (Author: vladimirsitnikov):
{{MyUnWrapFunction}} with {{Object}} argument works properly.
I guess the problem might be somewhere in [OptiqCatalogReader.toSql|https://github.com/apache/incubator-calcite/blob/master/core/src/main/java/net/hydromatic/optiq/prepare/OptiqCatalogReader.java#L248]

> User-defined functions should be able to use custom java arguments
> ------------------------------------------------------------------
>
>                 Key: CALCITE-455
>                 URL: https://issues.apache.org/jira/browse/CALCITE-455
>             Project: Calcite
>          Issue Type: Bug
>    Affects Versions: 0.9.1-incubating
>            Reporter: Vladimir Sitnikov
>            Assignee: Julian Hyde
>         Attachments: custom_argument_type_test.diff
>
>
> Calcite fails to recognize function that accepts custom java class.
> For instance, when trying to evaluate {{my_unwrap(my_wrap(42))}} I get {{SqlValidatorException: No match found for function signature MY_UNWRAP(<JavaType(class net.hydromatic.optiq.test.JdbcTest$MyIntWrapper)>)}}
> {code:java}
>   /** Un-wraps a user-defined wrapper into int */
>   public static class MyUnWrapFunction {
>     public static int eval(MyIntWrapper v) {
>       return v.v;
>     }
>   }
>   /** User-defined wraper to check custom datatype support. */
>   public static class MyIntWrapper {
>       public final int v;
>       public MyIntWrapper(int v) {
>           this.v=v;
>       }
>   }{code}
> {noformat}
> java.lang.RuntimeException: exception while executing [select "adhoc".my_unwrap("adhoc".my_wrap(42)) as p from "adhoc".EMPLOYEES]
> 	at net.hydromatic.optiq.test.OptiqAssert$AssertQuery.returns(OptiqAssert.java:1051)
> 	at net.hydromatic.optiq.test.OptiqAssert$AssertQuery.returns(OptiqAssert.java:1041)
> 	at net.hydromatic.optiq.test.OptiqAssert$AssertQuery.returns(OptiqAssert.java:1029)
> 	at net.hydromatic.optiq.test.JdbcTest.testJavaClassAsArgument(JdbcTest.java:5056)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> 	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
> 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
> 	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> 	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> 	at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> 	at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
> 	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:74)
> 	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:211)
> 	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:67)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:134)
> Caused by: java.lang.RuntimeException: With materializationsEnabled=false, limit=0
> 	at net.hydromatic.optiq.test.OptiqAssert.assertQuery(OptiqAssert.java:419)
> 	at net.hydromatic.optiq.test.OptiqAssert$AssertQuery.returns(OptiqAssert.java:1047)
> 	... 29 more
> Caused by: java.sql.SQLException: error while executing SQL "select "adhoc".my_unwrap("adhoc".my_wrap(42)) as p from "adhoc".EMPLOYEES": From line 1, column 16 to line 1, column 45: No match found for function signature MY_UNWRAP(<JavaType(class net.hydromatic.optiq.test.JdbcTest$MyIntWrapper)>)
> 	at net.hydromatic.avatica.Helper.createException(Helper.java:39)
> 	at net.hydromatic.avatica.AvaticaStatement.executeQuery(AvaticaStatement.java:79)
> 	at net.hydromatic.optiq.test.OptiqAssert.assertQuery(OptiqAssert.java:394)
> 	... 30 more
> Caused by: org.eigenbase.util.EigenbaseContextException: From line 1, column 16 to line 1, column 45: No match found for function signature MY_UNWRAP(<JavaType(class net.hydromatic.optiq.test.JdbcTest$MyIntWrapper)>)
> 	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> 	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> 	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> 	at java.lang.reflect.Constructor.newInstance(Constructor.java:408)
> 	at org.eigenbase.resource.Resources$ExInstWithCause.ex(Resources.java:348)
> 	at org.eigenbase.sql.SqlUtil.newContextException(SqlUtil.java:674)
> 	at org.eigenbase.sql.SqlUtil.newContextException(SqlUtil.java:659)
> 	at org.eigenbase.sql.validate.SqlValidatorImpl.newValidationError(SqlValidatorImpl.java:3551)
> 	at org.eigenbase.sql.validate.SqlValidatorImpl.handleUnresolvedFunction(SqlValidatorImpl.java:1432)
> 	at org.eigenbase.sql.SqlFunction.deriveType(SqlFunction.java:282)
> 	at org.eigenbase.sql.SqlFunction.deriveType(SqlFunction.java:206)
> 	at org.eigenbase.sql.validate.SqlValidatorImpl$DeriveTypeVisitor.visit(SqlValidatorImpl.java:3898)
> 	at org.eigenbase.sql.validate.SqlValidatorImpl$DeriveTypeVisitor.visit(SqlValidatorImpl.java:3885)
> 	at org.eigenbase.sql.SqlCall.accept(SqlCall.java:124)
> 	at org.eigenbase.sql.validate.SqlValidatorImpl.deriveTypeImpl(SqlValidatorImpl.java:1351)
> 	at org.eigenbase.sql.validate.SqlValidatorImpl.deriveType(SqlValidatorImpl.java:1334)
> 	at org.eigenbase.sql.SqlAsOperator.deriveType(SqlAsOperator.java:117)
> 	at org.eigenbase.sql.validate.SqlValidatorImpl$DeriveTypeVisitor.visit(SqlValidatorImpl.java:3898)
> 	at org.eigenbase.sql.validate.SqlValidatorImpl$DeriveTypeVisitor.visit(SqlValidatorImpl.java:3885)
> 	at org.eigenbase.sql.SqlCall.accept(SqlCall.java:124)
> 	at org.eigenbase.sql.validate.SqlValidatorImpl.deriveTypeImpl(SqlValidatorImpl.java:1351)
> 	at org.eigenbase.sql.validate.SqlValidatorImpl.deriveType(SqlValidatorImpl.java:1334)
> 	at org.eigenbase.sql.validate.SqlValidatorImpl.expandSelectItem(SqlValidatorImpl.java:418)
> 	at org.eigenbase.sql.validate.SqlValidatorImpl.validateSelectList(SqlValidatorImpl.java:3058)
> 	at org.eigenbase.sql.validate.SqlValidatorImpl.validateSelect(SqlValidatorImpl.java:2812)
> 	at org.eigenbase.sql.validate.SelectNamespace.validateImpl(SelectNamespace.java:59)
> 	at org.eigenbase.sql.validate.AbstractNamespace.validate(AbstractNamespace.java:84)
> 	at org.eigenbase.sql.validate.SqlValidatorImpl.validateNamespace(SqlValidatorImpl.java:747)
> 	at org.eigenbase.sql.validate.SqlValidatorImpl.validateQuery(SqlValidatorImpl.java:736)
> 	at org.eigenbase.sql.SqlSelect.validate(SqlSelect.java:207)
> 	at org.eigenbase.sql.validate.SqlValidatorImpl.validateScopedExpression(SqlValidatorImpl.java:710)
> 	at org.eigenbase.sql.validate.SqlValidatorImpl.validate(SqlValidatorImpl.java:426)
> 	at org.eigenbase.sql2rel.SqlToRelConverter.convertQuery(SqlToRelConverter.java:406)
> 	at net.hydromatic.optiq.prepare.Prepare.prepareSql(Prepare.java:212)
> 	at net.hydromatic.optiq.prepare.Prepare.prepareSql(Prepare.java:178)
> 	at net.hydromatic.optiq.prepare.OptiqPrepareImpl.prepare2_(OptiqPrepareImpl.java:417)
> 	at net.hydromatic.optiq.prepare.OptiqPrepareImpl.prepare_(OptiqPrepareImpl.java:322)
> 	at net.hydromatic.optiq.prepare.OptiqPrepareImpl.prepareSql(OptiqPrepareImpl.java:291)
> 	at net.hydromatic.optiq.jdbc.OptiqConnectionImpl.parseQuery(OptiqConnectionImpl.java:170)
> 	at net.hydromatic.optiq.jdbc.MetaImpl.prepare(MetaImpl.java:622)
> 	at net.hydromatic.avatica.AvaticaStatement.executeQuery(AvaticaStatement.java:76)
> 	... 31 more
> Caused by: org.eigenbase.sql.validate.SqlValidatorException: No match found for function signature MY_UNWRAP(<JavaType(class net.hydromatic.optiq.test.JdbcTest$MyIntWrapper)>)
> 	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> 	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> 	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> 	at java.lang.reflect.Constructor.newInstance(Constructor.java:408)
> 	at org.eigenbase.resource.Resources$ExInstWithCause.ex(Resources.java:348)
> 	at org.eigenbase.resource.Resources$ExInst.ex(Resources.java:457)
> 	... 67 more
> SEVERE: org.eigenbase.sql.validate.SqlValidatorException: No match found for function signature MY_UNWRAP(<JavaType(class net.hydromatic.optiq.test.JdbcTest$MyIntWrapper)>)
> ноя 06, 2014 9:07:17 PM org.eigenbase.util.EigenbaseException <init>
> SEVERE: org.eigenbase.util.EigenbaseContextException: From line 1, column 16 to line 1, column 45: No match found for function signature MY_UNWRAP(<JavaType(class net.hydromatic.optiq.test.JdbcTest$MyIntWrapper)>)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)