[GitHub] [superset] cccs-joel edited a comment on pull request #17360: fix: Change datatype of column type in BaseColumn to allow larger datatype names for complexed columns

[GitBox <gi...@apache.org>]

cccs-joel edited a comment on pull request #17360:
URL: https://github.com/apache/superset/pull/17360#issuecomment-978066531


   > > > 
   > > 
   > > 
   > > > Thanks to people smarter than I double checking the perf implications.
   > > > We definitely should have a note in UPDATING though, as this will probably be a table lock on mysql dbs. otherwise, lgtm
   > > 
   > > 
   > > Sorry, I'm new to this process, should I write this note?
   > 
   > Yeah, just add it to the file (https://github.com/apache/superset/blob/master/UPDATING.md) under the next release.
    Done here: https://github.com/apache/superset/pull/17541 assuming unless you want me to do it in this pull request.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org