You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/03/31 19:44:00 UTC

[jira] [Commented] (GEODE-10141) GMSJoinLeaveJUnitTest is overly specific about the expected exception message

    [ https://issues.apache.org/jira/browse/GEODE-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515552#comment-17515552 ] 

ASF subversion and git services commented on GEODE-10141:
---------------------------------------------------------

Commit 59af2c83865dcea5efd4760c0fa4c3012fb3ad7f in geode's branch refs/heads/develop from Darrel Schneider
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=59af2c8 ]

GEODE-10141: remove test expectation of toString format (#7525)

Test now asks the GMSJoinLeave for its locators and validates
that they are in the exception message instead of having a test
expectation of how InetAddress will be formatted in this exception.

> GMSJoinLeaveJUnitTest is overly specific about the expected exception message
> -----------------------------------------------------------------------------
>
>                 Key: GEODE-10141
>                 URL: https://issues.apache.org/jira/browse/GEODE-10141
>             Project: Geode
>          Issue Type: Improvement
>          Components: membership, tests
>    Affects Versions: 1.15.0
>            Reporter: Dale Emery
>            Assignee: Darrel Schneider
>            Priority: Major
>              Labels: Java17, pull-request-available
>             Fix For: 1.15.0
>
>
> `GMSJoinLeave` throws the correct exception type, with a message correctly describing its inability to connect to the locators at the specified unresolved addresses. But the test's assertion is overly specific about the description of an unresolved address, and fails on JDK 17.
> In JDKs up through 13, `toString()` of an unresolved `InetSocketAddress` returned `"hostname:port"`. Starting with JDK 14 it returns `"hostname/<unresolved>:port"`. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)