You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2023/07/12 17:47:47 UTC
[GitHub] [accumulo] keith-turner opened a new pull request, #3601: syncs ZK before reading root tablet metadata
keith-turner opened a new pull request, #3601:
URL: https://github.com/apache/accumulo/pull/3601
While working on metadata code in the elasticity branch, I realized it would be good to sync ZK before reading the root tablet metadata. Did not want to make that change only in the elasticity branch and it seemed like a good change for 2.1.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on a diff in pull request #3601: syncs ZK before reading root tablet metadata
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #3601:
URL: https://github.com/apache/accumulo/pull/3601#discussion_r1263662242
##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletsMetadata.java:
##########
@@ -537,7 +537,11 @@ private static TabletMetadata getRootMetadata(ClientContext ctx,
case IMMEDIATE:
ZooReader zooReader = ctx.getZooReader();
try {
- byte[] bytes = zooReader.getData(zkRoot + RootTable.ZROOT_TABLET);
+ var path = zkRoot + RootTable.ZROOT_TABLET;
Review Comment:
I wonder if eventual should even be supported for the root table. Maybe it should always be immediate regardless of consistency level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner merged pull request #3601: syncs ZK before reading root tablet metadata
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner merged PR #3601:
URL: https://github.com/apache/accumulo/pull/3601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner commented on a diff in pull request #3601: syncs ZK before reading root tablet metadata
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #3601:
URL: https://github.com/apache/accumulo/pull/3601#discussion_r1265783695
##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletsMetadata.java:
##########
@@ -537,7 +537,11 @@ private static TabletMetadata getRootMetadata(ClientContext ctx,
case IMMEDIATE:
ZooReader zooReader = ctx.getZooReader();
try {
- byte[] bytes = zooReader.getData(zkRoot + RootTable.ZROOT_TABLET);
+ var path = zkRoot + RootTable.ZROOT_TABLET;
Review Comment:
I think the evenutal case was for code that used to use zoocache to read root tablet metadata that was adpated to use Ample. That code did not care if it got the latest and greatest, it just wanted performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org