[GitHub] [pulsar] merlimat commented on a change in pull request #5574: Add Github workflow for gated checkin

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #5574: Add Github workflow for gated checkin 
URL: https://github.com/apache/pulsar/pull/5574#discussion_r343852759
 
 

 ##########
 File path: pulsar-broker/src/test/java/org/apache/pulsar/websocket/proxy/ProxyPublishConsumeTlsTest.java
 ##########
 @@ -76,6 +76,8 @@ public void setup() throws Exception {
         config.setBrokerClientAuthenticationParameters("tlsCertFile:" + TLS_CLIENT_CERT_FILE_PATH + ",tlsKeyFile:" + TLS_CLIENT_KEY_FILE_PATH);
         config.setBrokerClientAuthenticationPlugin(AuthenticationTls.class.getName());
         String lookupUrl = new URI("pulsar://localhost:" + BROKER_PORT_TLS).toString();
+        // Add the required number of thread for testing in low core count machines
+        config.setNumHttpServerThreads(6);
 
 Review comment:
   Since this will be a problem in any case, we should make sure we do `Math.max(6, config.getNumHttpServerThreads())` instead of just setting it for tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services