[GitHub] [cordova-android] breautek opened a new pull request #792: Updated gradle from 4.10.3 to 5.5.1

[GitBox <gi...@apache.org>]

breautek opened a new pull request #792: Updated gradle from 4.10.3 to 5.5.1
URL: https://github.com/apache/cordova-android/pull/792
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Android
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   Updates gradle version to the latest release (currently 5.5.1). It solves a few issue tickets that supposedly was caused after upgrading Android Studio.
   <!-- If it fixes an open issue, please link to the issue here. -->
   Fixes #780 #754 #718 
   
   
   ### Description
   Changed the desired gradle version from 4.10.3 to 5.5.1
   
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   I have tested using `npm test` and all tests passed. Note that if you have ran `npm test` before, you will need to remove the `/test/gradlew` file so the test project will download the new gradle version.
   
   I have also tested by creating a brand new cordova app, and adding the `cordova-android` platform by using `cordova platform add https://github.com/breautek/cordova-android.git#gradle-5.x`
   Then running the `cordova build android` command.
   
   I'd also like to make a note that gradle 5.5.1 does currently produce a warning stating:
   
   > Deprecated Gradle features were used in this build, making it incompatible with Gradle 6.0.
   
   Running gradlew manually with `--verbose --stacktrace`  shows the code triggering the warning is android internal code.
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org