svn commit: r470596 - in /maven/shared/trunk/maven-plugin-tools/maven-plugin-tools-java/src: main/java/org/apache/maven/tools/plugin/extractor/java/ test/java/org/apache/maven/tools/plugin/extractor/java/

[vs...@apache.org]

Author: vsiveton
Date: Thu Nov  2 15:30:34 2006
New Revision: 470596

URL: http://svn.apache.org/viewvc?view=rev&rev=470596
Log:
MNG-2164:Generated plugin documentation lists wrong data type
Submitted by: Hervé BOUTEMY 
Reviewed by: Vincent Siveton

o applied with the correct Code Style

Thanks!

Modified:
    maven/shared/trunk/maven-plugin-tools/maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/java/JavaMojoDescriptorExtractor.java
    maven/shared/trunk/maven-plugin-tools/maven-plugin-tools-java/src/test/java/org/apache/maven/tools/plugin/extractor/java/JavaMojoDescriptorExtractorTest.java

Modified: maven/shared/trunk/maven-plugin-tools/maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/java/JavaMojoDescriptorExtractor.java
URL: http://svn.apache.org/viewvc/maven/shared/trunk/maven-plugin-tools/maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/java/JavaMojoDescriptorExtractor.java?view=diff&rev=470596&r1=470595&r2=470596
==============================================================================
--- maven/shared/trunk/maven-plugin-tools/maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/java/JavaMojoDescriptorExtractor.java (original)
+++ maven/shared/trunk/maven-plugin-tools/maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/java/JavaMojoDescriptorExtractor.java Thu Nov  2 15:30:34 2006
@@ -21,6 +21,8 @@
 import com.thoughtworks.qdox.model.JavaClass;
 import com.thoughtworks.qdox.model.JavaField;
 import com.thoughtworks.qdox.model.JavaSource;
+import com.thoughtworks.qdox.model.Type;
+
 import org.apache.maven.plugin.descriptor.InvalidParameterException;
 import org.apache.maven.plugin.descriptor.InvalidPluginDescriptorException;
 import org.apache.maven.plugin.descriptor.MojoDescriptor;
@@ -378,9 +380,27 @@
 
             JavaField field = (JavaField) entry.getValue();
 
+            Type type = field.getType();
+
             Parameter pd = new Parameter();
 
-            pd.setType( field.getType().getValue() );
+            if ( !type.isArray() )
+            {
+                pd.setType( type.getValue() );
+            }
+            else
+            {
+                StringBuffer value = new StringBuffer( type.getValue() );
+
+                int remaining = type.getDimensions();
+
+                while ( remaining-- > 0 )
+                {
+                    value.append( "[]" );
+                }
+
+                pd.setType( value.toString() );
+            }
 
             pd.setDescription( field.getComment() );
 

Modified: maven/shared/trunk/maven-plugin-tools/maven-plugin-tools-java/src/test/java/org/apache/maven/tools/plugin/extractor/java/JavaMojoDescriptorExtractorTest.java
URL: http://svn.apache.org/viewvc/maven/shared/trunk/maven-plugin-tools/maven-plugin-tools-java/src/test/java/org/apache/maven/tools/plugin/extractor/java/JavaMojoDescriptorExtractorTest.java?view=diff&rev=470596&r1=470595&r2=470596
==============================================================================
--- maven/shared/trunk/maven-plugin-tools/maven-plugin-tools-java/src/test/java/org/apache/maven/tools/plugin/extractor/java/JavaMojoDescriptorExtractorTest.java (original)
+++ maven/shared/trunk/maven-plugin-tools/maven-plugin-tools-java/src/test/java/org/apache/maven/tools/plugin/extractor/java/JavaMojoDescriptorExtractorTest.java Thu Nov  2 15:30:34 2006
@@ -56,6 +56,15 @@
         pluginDescriptor.setGoalPrefix( "test" );
         List results = extractor.execute( project, pluginDescriptor );
         assertEquals( "Extracted mojos", 2, results.size() );
+
+        for ( int i = 0; i < 2; i++ )
+        {
+            MojoDescriptor mojoDescriptor = (MojoDescriptor) results.get( i );
+            assertEquals( 1, mojoDescriptor.getParameters().size() );
+            Parameter parameter = (Parameter) mojoDescriptor.getParameters().get( 0 );
+            assertEquals( "project", parameter.getName() );
+            assertEquals( "java.lang.String[]", parameter.getType() );
+        }
     }
 
     public void testShouldPropagateImplementationParameter()