You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by afine <gi...@git.apache.org> on 2017/04/07 02:39:34 UTC
[GitHub] zookeeper pull request #220: ZOOKEEPER-2729: Cleanup findbug warnings in bra...
GitHub user afine opened a pull request:
https://github.com/apache/zookeeper/pull/220
ZOOKEEPER-2729: Cleanup findbug warnings in branch-3.4: Correctness Warnings
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afine/zookeeper ZOOKEEPER-2729
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/220.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #220
----
commit a2a0a9840d271ab6c3151f8b4917dfa0b3c72a8a
Author: Abraham Fine <af...@apache.org>
Date: 2017-04-07T02:38:26Z
ZOOKEEPER-2729: Cleanup findbug warnings in branch-3.4: Correctness Warnings
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #220: ZOOKEEPER-2729: Cleanup findbug warnings in bra...
Posted by afine <gi...@git.apache.org>.
Github user afine closed the pull request at:
https://github.com/apache/zookeeper/pull/220
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #220: ZOOKEEPER-2729: Cleanup findbug warnings in branch-3.4...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/220
lgtm.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #220: ZOOKEEPER-2729: Cleanup findbug warnings in branch-3.4...
Posted by afine <gi...@git.apache.org>.
Github user afine commented on the issue:
https://github.com/apache/zookeeper/pull/220
@rakeshadr @hanm
Both of the findbugs related issues here appear to be from from ZOOKEEPER-1045. There were checks for an array length of less than zero `if (response != null && response.length < 0) {`.
According to the java spec (http://docs.oracle.com/javase/specs/jls/se7/html/jls-10.html#jls-10.7) this is an impossible condition.
>The public final field length, which contains the number of components of the array. length may be positive or zero.
So I just remove the clause from the if block, please let me know if I am missing something.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #220: ZOOKEEPER-2729: Cleanup findbug warnings in branch-3.4...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/220
merged, please close pr @afine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #220: ZOOKEEPER-2729: Cleanup findbug warnings in branch-3.4...
Posted by afine <gi...@git.apache.org>.
Github user afine commented on the issue:
https://github.com/apache/zookeeper/pull/220
The javadoc warning from jenkins appears to be unrelated to the patch:
> [javadoc] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java:207: warning - @return tag has no arguments.
The new findbugs appears to be incorrect as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---