You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Yao Li <be...@126.com> on 2018/04/13 15:04:39 UTC
Re: Review Request 65435: ATLAS-2298 - Review of OCF Database
Connector_New
> On March 26, 2018, 2 p.m., David Radley wrote:
> > ocf-database-connector/src/main/resources/gaian.properties
> > Lines 6 (patched)
> > <https://reviews.apache.org/r/65435/diff/2/?file=1985292#file1985292line6>
> >
> > It does not look right to include default passwords here, without talking about poc / dev scenarios and not production scenarios
>
> Yao Li wrote:
> for now I am still not sure where do we store the information for the front-end Gaian. For now I just set it up as a properties file. I dont know these password will be stored in a central properties file or also OCF Connection for every asset. I will keep this issue open.
I have deleted the properties file for the new patch. for now if we want to use Gaian, The front-end application have to know where the Gaian is. GaianOCFConnector offer a constructor which contains all the set up for connecting to Gaian.
- Yao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65435/#review199965
-----------------------------------------------------------
On March 30, 2018, 9:33 a.m., Yao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65435/
> -----------------------------------------------------------
>
> (Updated March 30, 2018, 9:33 a.m.)
>
>
> Review request for atlas and Mandy Chessell.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This is the new review request for ATLAS-2298 OCF Database Connector. The old review on [https://reviews.apache.org/r/65123/](https://reviews.apache.org/r/65123/) will not be updated anymore.
>
> The OCF Database Connector is the subclass of OCF Connector and it is designed especially for connection to database to retrieve data.
> Here we implement a connector for Gaian (GaianOCFConnector) as an example for using OCF Database Connector. It is related to Open Connector Framework. The JIRA can be found https://issues.apache.org/jira/browse/ATLAS-2298
>
>
> Diffs
> -----
>
> ocf-database-connector/README.md PRE-CREATION
> ocf-database-connector/pom.xml PRE-CREATION
> ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/connectors/OCFDatabaseConnection.java PRE-CREATION
> ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/connectors/OCFDatabaseConnector.java PRE-CREATION
> ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/connectors/OCFDatabaseConnectorProviderBase.java PRE-CREATION
> ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/connectors/gaian/GaianOCFConnector.java PRE-CREATION
> ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/connectors/gaian/GaianOCFConnectorProvider.java PRE-CREATION
> ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/ffdc/DatabaseConnectCheckedException.java PRE-CREATION
> ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/ffdc/OCFDatabaseCheckedExceptionBase.java PRE-CREATION
> ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/ffdc/OCFDatabaseConnectorErrorCode.java PRE-CREATION
> ocf-database-connector/src/main/java/org/apache/atlas/ocfdbconnector/ffdc/OCFDatabaseConnectorRuntimeException.java PRE-CREATION
> ocf-database-connector/src/test/java/gaianocfconnector/GaianOCFConnectorTest.java PRE-CREATION
> ocf-database-connector/src/test/java/gaianocfconnector/UseGaianOCFConnector.java PRE-CREATION
> pom.xml ee2746a905f84359d426acfb1fa6d64c6310aaaf
>
>
> Diff: https://reviews.apache.org/r/65435/diff/5/
>
>
> Testing
> -------
>
> see test folder.
> Gaian has to set up in advance
>
>
> File Attachments
> ----------------
>
> 0005-ATLAS-2298-05-Feb-code-review.patch
> https://reviews.apache.org/media/uploaded/files/2018/02/05/292c1917-9deb-4ced-8bd6-1689fc45fbd4__0005-ATLAS-2298-05-Feb-code-review.patch
>
>
> Thanks,
>
> Yao Li
>
>