You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Syed Albiz <s....@gmail.com> on 2011/08/03 01:18:29 UTC
Review Request: HIVE-2335: Indexes are still automatically queried when out
of sync with their source tables
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1260/
-----------------------------------------------------------
Review request for hive, John Sichi, Yongqiang He, and Ning Zhang.
Summary
-------
Check the timestamps of the tables/partitions to ensure that they were not written to since the index was last generated
This addresses bug HIVE-2335.
https://issues.apache.org/jira/browse/HIVE-2335
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java 8295687
ql/src/test/queries/clientpositive/index_stale.q PRE-CREATION
ql/src/test/queries/clientpositive/index_stale_partitioned.q PRE-CREATION
ql/src/test/results/clientpositive/index_stale.q.out PRE-CREATION
ql/src/test/results/clientpositive/index_stale_partitioned.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1260/diff
Testing
-------
added index_stale.q and index_stale_partitioned.q to the testcase suite
Thanks,
Syed
Re: Review Request: HIVE-2335: Indexes are still automatically queried when
out of sync with their source tables
Posted by Syed Albiz <s....@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1260/
-----------------------------------------------------------
(Updated 2011-08-18 10:08:30.148104)
Review request for hive, John Sichi, Yongqiang He, and Ning Zhang.
Changes
-------
updated testcases
Summary
-------
Check the timestamps of the tables/partitions to ensure that they were not written to since the index was last generated
This addresses bug HIVE-2335.
https://issues.apache.org/jira/browse/HIVE-2335
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java 8295687
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 3054f76
ql/src/java/org/apache/hadoop/hive/ql/plan/AlterIndexDesc.java cf20b89
ql/src/test/queries/clientpositive/index_stale.q PRE-CREATION
ql/src/test/queries/clientpositive/index_stale_partitioned.q PRE-CREATION
ql/src/test/results/clientpositive/index_stale.q.out PRE-CREATION
ql/src/test/results/clientpositive/index_stale_partitioned.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1260/diff
Testing
-------
added index_stale.q and index_stale_partitioned.q to the testcase suite
Thanks,
Syed
Re: Review Request: HIVE-2335: Indexes are still automatically queried when
out of sync with their source tables
Posted by Syed Albiz <s....@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1260/
-----------------------------------------------------------
(Updated 2011-08-17 00:57:46.951422)
Review request for hive, John Sichi, Yongqiang He, and Ning Zhang.
Changes
-------
Ning pointed out that there was a race condition with the approach I was using, modified to store the timestamps of the base tables before we kick off the rebuild job.
Summary
-------
Check the timestamps of the tables/partitions to ensure that they were not written to since the index was last generated
This addresses bug HIVE-2335.
https://issues.apache.org/jira/browse/HIVE-2335
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java 8295687
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 3054f76
ql/src/java/org/apache/hadoop/hive/ql/plan/AlterIndexDesc.java cf20b89
ql/src/test/queries/clientpositive/index_stale.q PRE-CREATION
ql/src/test/queries/clientpositive/index_stale_partitioned.q PRE-CREATION
ql/src/test/results/clientpositive/index_stale.q.out PRE-CREATION
ql/src/test/results/clientpositive/index_stale_partitioned.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1260/diff
Testing
-------
added index_stale.q and index_stale_partitioned.q to the testcase suite
Thanks,
Syed