You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yx9o (via GitHub)" <gi...@apache.org> on 2023/08/18 14:25:10 UTC

[GitHub] [rocketmq] yx9o opened a new pull request, #7210: [ISSUE #7166] Optimize the display format of admin

yx9o opened a new pull request, #7210:
URL: https://github.com/apache/rocketmq/pull/7210

   
   Fixes #7166, optimize the display format of admin.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] codecov-commenter commented on pull request #7210: [ISSUE #7166] Optimize the display format of admin

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7210:
URL: https://github.com/apache/rocketmq/pull/7210#issuecomment-1684030659

   ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7210?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#7210](https://app.codecov.io/gh/apache/rocketmq/pull/7210?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (313d357) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/72d796f2b20b3ec6aebca8c004d9275d7c749a95?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (72d796f) will **decrease** coverage by `0.04%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #7210      +/-   ##
   =============================================
   - Coverage      42.46%   42.43%   -0.04%     
   + Complexity      9353     9347       -6     
   =============================================
     Files           1149     1149              
     Lines          82111    82111              
     Branches       10703    10703              
   =============================================
   - Hits           34868    34843      -25     
   - Misses         42882    42899      +17     
   - Partials        4361     4369       +8     
   ```
   
   
   | [Files Changed](https://app.codecov.io/gh/apache/rocketmq/pull/7210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../apache/rocketmq/tools/command/MQAdminStartup.java](https://app.codecov.io/gh/apache/rocketmq/pull/7210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvTVFBZG1pblN0YXJ0dXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...and/acl/ClusterAclConfigVersionListSubCommand.java](https://app.codecov.io/gh/apache/rocketmq/pull/7210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvYWNsL0NsdXN0ZXJBY2xDb25maWdWZXJzaW9uTGlzdFN1YkNvbW1hbmQuamF2YQ==) | `20.40% <0.00%> (ø)` | |
   | [...ools/command/acl/DeleteAccessConfigSubCommand.java](https://app.codecov.io/gh/apache/rocketmq/pull/7210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvYWNsL0RlbGV0ZUFjY2Vzc0NvbmZpZ1N1YkNvbW1hbmQuamF2YQ==) | `31.70% <0.00%> (ø)` | |
   | [...q/tools/command/acl/GetAccessConfigSubCommand.java](https://app.codecov.io/gh/apache/rocketmq/pull/7210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvYWNsL0dldEFjY2Vzc0NvbmZpZ1N1YkNvbW1hbmQuamF2YQ==) | `19.60% <0.00%> (ø)` | |
   | [...ools/command/acl/UpdateAccessConfigSubCommand.java](https://app.codecov.io/gh/apache/rocketmq/pull/7210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvYWNsL1VwZGF0ZUFjY2Vzc0NvbmZpZ1N1YkNvbW1hbmQuamF2YQ==) | `39.53% <0.00%> (ø)` | |
   | [...s/command/acl/UpdateGlobalWhiteAddrSubCommand.java](https://app.codecov.io/gh/apache/rocketmq/pull/7210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvYWNsL1VwZGF0ZUdsb2JhbFdoaXRlQWRkclN1YkNvbW1hbmQuamF2YQ==) | `36.36% <0.00%> (ø)` | |
   | [...ls/command/broker/BrokerConsumeStatsSubCommad.java](https://app.codecov.io/gh/apache/rocketmq/pull/7210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvYnJva2VyL0Jyb2tlckNvbnN1bWVTdGF0c1N1YkNvbW1hZC5qYXZh) | `40.27% <0.00%> (ø)` | |
   | [...q/tools/command/broker/BrokerStatusSubCommand.java](https://app.codecov.io/gh/apache/rocketmq/pull/7210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvYnJva2VyL0Jyb2tlclN0YXR1c1N1YkNvbW1hbmQuamF2YQ==) | `50.00% <0.00%> (ø)` | |
   | [...ommand/broker/CommitLogSetReadAheadSubCommand.java](https://app.codecov.io/gh/apache/rocketmq/pull/7210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvYnJva2VyL0NvbW1pdExvZ1NldFJlYWRBaGVhZFN1YkNvbW1hbmQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...mmand/broker/DeleteExpiredCommitLogSubCommand.java](https://app.codecov.io/gh/apache/rocketmq/pull/7210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvYnJva2VyL0RlbGV0ZUV4cGlyZWRDb21taXRMb2dTdWJDb21tYW5kLmphdmE=) | `65.62% <0.00%> (ø)` | |
   | ... and [49 more](https://app.codecov.io/gh/apache/rocketmq/pull/7210?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [39 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/7210/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] RongtongJin commented on pull request #7210: [ISSUE #7166] Optimize the display format of admin

Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin commented on PR #7210:
URL: https://github.com/apache/rocketmq/pull/7210#issuecomment-1689087251

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] RongtongJin merged pull request #7210: [ISSUE #7166] Optimize the display format of admin

Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin merged PR #7210:
URL: https://github.com/apache/rocketmq/pull/7210


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org