You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@streams.apache.org by sb...@apache.org on 2017/06/21 03:30:04 UTC
[4/4] incubator-streams git commit: PR feedback
PR feedback
Project: http://git-wip-us.apache.org/repos/asf/incubator-streams/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-streams/commit/bd91d268
Tree: http://git-wip-us.apache.org/repos/asf/incubator-streams/tree/bd91d268
Diff: http://git-wip-us.apache.org/repos/asf/incubator-streams/diff/bd91d268
Branch: refs/heads/master
Commit: bd91d2687fa76fea10c33d73d72c595bde6a656a
Parents: b1c540d
Author: Steve Blackmon <sb...@apache.org>
Authored: Tue Jun 20 21:40:55 2017 -0500
Committer: Steve Blackmon <sb...@apache.org>
Committed: Tue Jun 20 21:40:55 2017 -0500
----------------------------------------------------------------------
.../main/java/org/apache/streams/twitter/api/Account.java | 3 ++-
.../main/java/org/apache/streams/twitter/api/Followers.java | 4 ++--
.../main/java/org/apache/streams/twitter/api/Friends.java | 4 ++--
.../main/java/org/apache/streams/twitter/api/Statuses.java | 2 +-
.../main/java/org/apache/streams/twitter/api/Twitter.java | 1 -
.../org/apache/streams/twitter/api/TwitterRetryHandler.java | 8 ++++----
.../src/main/java/org/apache/streams/twitter/api/Users.java | 4 ++--
.../apache/streams/twitter/api/AccountSettingsResponse.json | 3 ---
8 files changed, 13 insertions(+), 16 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/bd91d268/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Account.java
----------------------------------------------------------------------
diff --git a/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Account.java b/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Account.java
index f031514..dfe0c4e 100644
--- a/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Account.java
+++ b/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Account.java
@@ -26,6 +26,7 @@ import org.apache.juneau.remoteable.Remoteable;
import java.util.List;
/**
+ * Interface for /account methods.
*/
@Remoteable(path = "https://api.twitter.com/1.1/account")
public interface Account {
@@ -41,7 +42,7 @@ public interface Account {
public AccountSettings settings();
/**
- * Returns settings (including current trend, geo and sleep time information) for the authenticating user.
+ * Returns user credentials for the authenticating user.
*
* @return User
* @see <a href=https://dev.twitter.com/rest/reference/get/account/verify_credentials">https://dev.twitter.com/rest/reference/get/account/verify_credentials</a>
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/bd91d268/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Followers.java
----------------------------------------------------------------------
diff --git a/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Followers.java b/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Followers.java
index 41dfbde..8c2698b 100644
--- a/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Followers.java
+++ b/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Followers.java
@@ -38,7 +38,7 @@ public interface Followers {
* Returns a cursored collection of user IDs for every user following the specified user.
*
* @param parameters {@link org.apache.streams.twitter.api.FollowersIdsRequest}
- * @return List < Tweet >
+ * @return FollowersIdsResponse
* @see <a href="https://dev.twitter.com/rest/reference/get/followers/ids">https://dev.twitter.com/rest/reference/get/followers/ids</a>
*
*/
@@ -49,7 +49,7 @@ public interface Followers {
* Returns a cursored collection of user objects for users following the specified user.
*
* @param parameters {@link org.apache.streams.twitter.api.FollowersListRequest}
- * @return List < Tweet >
+ * @return FollowersListResponse
* @see <a href="https://dev.twitter.com/rest/reference/get/followers/list">https://dev.twitter.com/rest/reference/get/followers/list</a>
*
*/
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/bd91d268/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Friends.java
----------------------------------------------------------------------
diff --git a/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Friends.java b/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Friends.java
index dbe5e49..7f75603 100644
--- a/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Friends.java
+++ b/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Friends.java
@@ -38,7 +38,7 @@ public interface Friends {
* Returns a cursored collection of user IDs for every user the specified user is following.
*
* @param parameters {@link org.apache.streams.twitter.api.FriendsIdsRequest}
- * @return List<Tweet>
+ * @return FriendsIdsResponse
* @see <a href="https://dev.twitter.com/rest/reference/get/friends/ids">https://dev.twitter.com/rest/reference/get/friends/ids</a>
*
*/
@@ -49,7 +49,7 @@ public interface Friends {
* Returns a cursored collection of user objects for every user the specified user is following.
*
* @param parameters {@link org.apache.streams.twitter.api.FriendsListRequest}
- * @return List<Tweet>
+ * @return FriendsListResponse
* @see <a href="https://dev.twitter.com/rest/reference/get/friends/list">https://dev.twitter.com/rest/reference/get/friends/list</a>
*
*/
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/bd91d268/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Statuses.java
----------------------------------------------------------------------
diff --git a/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Statuses.java b/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Statuses.java
index e0177d9..65f3882 100644
--- a/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Statuses.java
+++ b/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Statuses.java
@@ -79,7 +79,7 @@ public interface Statuses {
* Returns a single Tweet, specified by the id parameter. The Tweet’s author will also be embedded within the Tweet.
*
* @param parameters {@link org.apache.streams.twitter.api.StatusesShowRequest}
- * @return List<Tweet>
+ * @return Tweet
* @see <a href="https://dev.twitter.com/rest/reference/get/statuses/show/id">https://dev.twitter.com/rest/reference/get/statuses/show/id</a>
*
*/
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/bd91d268/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Twitter.java
----------------------------------------------------------------------
diff --git a/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Twitter.java b/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Twitter.java
index 85150d8..db300b1 100644
--- a/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Twitter.java
+++ b/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Twitter.java
@@ -130,7 +130,6 @@ public class Twitter implements Account, Favorites, Followers, Friends, Statuses
return result;
}
- // TODO: juneau-6.3.x-incubating
@Override
public List<Tweet> homeTimeline(StatusesHomeTimelineRequest parameters) {
Statuses restStatuses = restClient.getRemoteableProxy(Statuses.class, TwitterProviderUtil.baseUrl(configuration)+"/statuses");
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/bd91d268/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/TwitterRetryHandler.java
----------------------------------------------------------------------
diff --git a/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/TwitterRetryHandler.java b/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/TwitterRetryHandler.java
index 27e2827..d068b47 100644
--- a/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/TwitterRetryHandler.java
+++ b/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/TwitterRetryHandler.java
@@ -78,10 +78,10 @@ public class TwitterRetryHandler extends RetryOn {
String responseEntity = EntityUtils.toString(response.getEntity());
LOGGER.debug(responseEntity);
responseErrors = JsonParser.DEFAULT.parse(responseEntity, ResponseErrors.class);
- } catch (IOException e) {
- e.printStackTrace();
- } catch (ParseException e) {
- e.printStackTrace();
+ } catch (IOException ex) {
+ LOGGER.error("IOException", ex);
+ } catch (ParseException ex) {
+ LOGGER.error("ParseException", ex);
}
}
return responseErrors;
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/bd91d268/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Users.java
----------------------------------------------------------------------
diff --git a/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Users.java b/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Users.java
index cc58dd7..a7b1a8f 100644
--- a/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Users.java
+++ b/streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/api/Users.java
@@ -41,7 +41,7 @@ public interface Users {
* Returns fully-hydrated user objects for up to 100 users per request, as specified by comma-separated values passed to the user_id and/or screen_name parameters.
*
* @param parameters {@link org.apache.streams.twitter.api.UsersLookupRequest}
- * @return List<Tweet>
+ * @return List<User>
* @see <a href="https://dev.twitter.com/rest/reference/get/users/lookup">https://dev.twitter.com/rest/reference/get/users/lookup</a>
*
*/
@@ -52,7 +52,7 @@ public interface Users {
* Returns a variety of information about the user specified by the required user_id or screen_name parameter. The author’s most recent Tweet will be returned inline when possible.
*
* @param parameters {@link org.apache.streams.twitter.api.UsersShowRequest}
- * @return List<Tweet>
+ * @return List<User>
* @see <a href="https://dev.twitter.com/rest/reference/get/users/show">https://dev.twitter.com/rest/reference/get/users/show</a>
*
*/
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/bd91d268/streams-contrib/streams-provider-twitter/src/main/jsonschema/org/apache/streams/twitter/api/AccountSettingsResponse.json
----------------------------------------------------------------------
diff --git a/streams-contrib/streams-provider-twitter/src/main/jsonschema/org/apache/streams/twitter/api/AccountSettingsResponse.json b/streams-contrib/streams-provider-twitter/src/main/jsonschema/org/apache/streams/twitter/api/AccountSettingsResponse.json
index 760d2b5..1b6ce36 100644
--- a/streams-contrib/streams-provider-twitter/src/main/jsonschema/org/apache/streams/twitter/api/AccountSettingsResponse.json
+++ b/streams-contrib/streams-provider-twitter/src/main/jsonschema/org/apache/streams/twitter/api/AccountSettingsResponse.json
@@ -22,9 +22,6 @@
"language": {
"type": "string"
},
- "language": {
- "type": "string"
- },
"protected": {
"type": "boolean"
},