You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-commits@xmlgraphics.apache.org by me...@apache.org on 2012/02/14 15:48:00 UTC
svn commit: r1243963 - in /xmlgraphics/fop/trunk: build.xml
test/java/org/apache/fop/fo/pagination/RepeatablePageMasterAlternativesTestCase.java
test/layoutengine/disabled-testcases.xml
Author: mehdi
Date: Tue Feb 14 14:48:00 2012
New Revision: 1243963
URL: http://svn.apache.org/viewvc?rev=1243963&view=rev
Log:
Enabled assertions in junit tasks (analagous to JVM arg -ea)
- Disabled a layout test that fails an assertion
- Added an expression to a mocked class to pass assertion
Modified:
xmlgraphics/fop/trunk/build.xml
xmlgraphics/fop/trunk/test/java/org/apache/fop/fo/pagination/RepeatablePageMasterAlternativesTestCase.java
xmlgraphics/fop/trunk/test/layoutengine/disabled-testcases.xml
Modified: xmlgraphics/fop/trunk/build.xml
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/build.xml?rev=1243963&r1=1243962&r2=1243963&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/build.xml (original)
+++ xmlgraphics/fop/trunk/build.xml Tue Feb 14 14:48:00 2012
@@ -787,6 +787,9 @@ list of possible build targets.
<classpath>
<path refid="@{classpath}"/>
</classpath>
+ <assertions>
+ <enable/>
+ </assertions>
<test name="@{testsuite}" todir="${junit.reports.dir}" outfile="@{outfile}"/>
</junit>
</sequential>
@@ -801,6 +804,9 @@ list of possible build targets.
<classpath>
<path refid="standard-junit-classpath"/>
</classpath>
+ <assertions>
+ <enable/>
+ </assertions>
<batchtest todir="${junit.reports.dir}">
<fileset dir="${build.unit.tests.dir}" includes="**/*TestCase.class"/>
</batchtest>
Modified: xmlgraphics/fop/trunk/test/java/org/apache/fop/fo/pagination/RepeatablePageMasterAlternativesTestCase.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/test/java/org/apache/fop/fo/pagination/RepeatablePageMasterAlternativesTestCase.java?rev=1243963&r1=1243962&r2=1243963&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/test/java/org/apache/fop/fo/pagination/RepeatablePageMasterAlternativesTestCase.java (original)
+++ xmlgraphics/fop/trunk/test/java/org/apache/fop/fo/pagination/RepeatablePageMasterAlternativesTestCase.java Tue Feb 14 14:48:00 2012
@@ -158,6 +158,7 @@ implements Constants {
when(pList.get(anyInt())).thenReturn(maximumRepeats);
PageSequenceMaster parent = mock(PageSequenceMaster.class);
+ when(parent.getName()).thenReturn("fo:page-sequence-master");
RepeatablePageMasterAlternatives sut = new RepeatablePageMasterAlternatives(parent);
Modified: xmlgraphics/fop/trunk/test/layoutengine/disabled-testcases.xml
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/test/layoutengine/disabled-testcases.xml?rev=1243963&r1=1243962&r2=1243963&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/test/layoutengine/disabled-testcases.xml (original)
+++ xmlgraphics/fop/trunk/test/layoutengine/disabled-testcases.xml Tue Feb 14 14:48:00 2012
@@ -209,4 +209,9 @@
<description>The block should cause overflow in the
last column on the page, rather than be broken.</description>
</testcase>
+ <testcase>
+ <name>Block Container Reference Orientation Bug</name>
+ <file>block-container_reference-orientation_bug36391.xml</file>
+ <description>An assert is failing</description>
+ </testcase>
</disabled-testcases>
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-commits-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: fop-commits-help@xmlgraphics.apache.org
Re: svn commit: r1243963 - in /xmlgraphics/fop/trunk: build.xml
test/java/org/apache/fop/fo/pagination/RepeatablePageMasterAlternativesTestCase.java
test/layoutengine/disabled-testcases.xml
Posted by mehdi houshmand <me...@gmail.com>.
Sorry, I should have said, this was an issue spotted by Glenn Adams.
Thanks for flagging it up Glenn!
Mehdi
On 14 February 2012 14:48, <me...@apache.org> wrote:
> Author: mehdi
> Date: Tue Feb 14 14:48:00 2012
> New Revision: 1243963
>
> URL: http://svn.apache.org/viewvc?rev=1243963&view=rev
> Log:
> Enabled assertions in junit tasks (analagous to JVM arg -ea)
>
> - Disabled a layout test that fails an assertion
> - Added an expression to a mocked class to pass assertion
>
> Modified:
> xmlgraphics/fop/trunk/build.xml
> xmlgraphics/fop/trunk/test/java/org/apache/fop/fo/pagination/RepeatablePageMasterAlternativesTestCase.java
> xmlgraphics/fop/trunk/test/layoutengine/disabled-testcases.xml
>
> Modified: xmlgraphics/fop/trunk/build.xml
> URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/build.xml?rev=1243963&r1=1243962&r2=1243963&view=diff
> ==============================================================================
> --- xmlgraphics/fop/trunk/build.xml (original)
> +++ xmlgraphics/fop/trunk/build.xml Tue Feb 14 14:48:00 2012
> @@ -787,6 +787,9 @@ list of possible build targets.
> <classpath>
> <path refid="@{classpath}"/>
> </classpath>
> + <assertions>
> + <enable/>
> + </assertions>
> <test name="@{testsuite}" todir="${junit.reports.dir}" outfile="@{outfile}"/>
> </junit>
> </sequential>
> @@ -801,6 +804,9 @@ list of possible build targets.
> <classpath>
> <path refid="standard-junit-classpath"/>
> </classpath>
> + <assertions>
> + <enable/>
> + </assertions>
> <batchtest todir="${junit.reports.dir}">
> <fileset dir="${build.unit.tests.dir}" includes="**/*TestCase.class"/>
> </batchtest>
>
> Modified: xmlgraphics/fop/trunk/test/java/org/apache/fop/fo/pagination/RepeatablePageMasterAlternativesTestCase.java
> URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/test/java/org/apache/fop/fo/pagination/RepeatablePageMasterAlternativesTestCase.java?rev=1243963&r1=1243962&r2=1243963&view=diff
> ==============================================================================
> --- xmlgraphics/fop/trunk/test/java/org/apache/fop/fo/pagination/RepeatablePageMasterAlternativesTestCase.java (original)
> +++ xmlgraphics/fop/trunk/test/java/org/apache/fop/fo/pagination/RepeatablePageMasterAlternativesTestCase.java Tue Feb 14 14:48:00 2012
> @@ -158,6 +158,7 @@ implements Constants {
> when(pList.get(anyInt())).thenReturn(maximumRepeats);
>
> PageSequenceMaster parent = mock(PageSequenceMaster.class);
> + when(parent.getName()).thenReturn("fo:page-sequence-master");
>
> RepeatablePageMasterAlternatives sut = new RepeatablePageMasterAlternatives(parent);
>
>
> Modified: xmlgraphics/fop/trunk/test/layoutengine/disabled-testcases.xml
> URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/test/layoutengine/disabled-testcases.xml?rev=1243963&r1=1243962&r2=1243963&view=diff
> ==============================================================================
> --- xmlgraphics/fop/trunk/test/layoutengine/disabled-testcases.xml (original)
> +++ xmlgraphics/fop/trunk/test/layoutengine/disabled-testcases.xml Tue Feb 14 14:48:00 2012
> @@ -209,4 +209,9 @@
> <description>The block should cause overflow in the
> last column on the page, rather than be broken.</description>
> </testcase>
> + <testcase>
> + <name>Block Container Reference Orientation Bug</name>
> + <file>block-container_reference-orientation_bug36391.xml</file>
> + <description>An assert is failing</description>
> + </testcase>
> </disabled-testcases>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: fop-commits-unsubscribe@xmlgraphics.apache.org
> For additional commands, e-mail: fop-commits-help@xmlgraphics.apache.org
>