You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/07 15:11:40 UTC

[GitHub] [airflow] fengsi opened a new issue #10223: Airflow configuration in web UI should recognize current settings rather than reading from `AIRFLOW_CONFIG` file

fengsi opened a new issue #10223:
URL: https://github.com/apache/airflow/issues/10223


   **Apache Airflow version**:
   1.10.11
   
   **What happened**:
   The `/configuration` URL is hard-coded to shows config in `AIRFLOW_CONFIG`, which is usually the `AIRFLOW_HOME/airflow.cfg` file:
   https://github.com/apache/airflow/blob/44d4ae809c1e3784ff95b6a5e95113c3412e56b3/airflow/www/views.py#L2133-L2134
   
   **What you expected to happen**:
   This `AIRFLOW_CONFIG` assumption is simply wrong.  It is very common for a user to define config as env vars, but those won't be reflected in this view at all.  All you get would be the default config, which is useless.
   
   We should use the same interface like in `airflow config` command to retrieve the real config:
   https://github.com/apache/airflow/blob/1d9a634d1dcb6f7d5816a38ccb5b967b074f918f/airflow/cli/commands/config_command.py#L32-L33
   
   **How to reproduce it**:
   Override config using env vars, and check the view.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil edited a comment on issue #10223: Airflow configuration in web UI should recognize current settings rather than reading from `AIRFLOW_CONFIG` file

Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on issue #10223:
URL: https://github.com/apache/airflow/issues/10223#issuecomment-670602035


   They are reflectled in the UI. There are 2 configurations on the UI:
   
   1) Configs from airflow.cfg
   2) Running Configuration


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] fengsi commented on issue #10223: Airflow configuration in web UI should recognize current settings rather than reading from `AIRFLOW_CONFIG` file

Posted by GitBox <gi...@apache.org>.
fengsi commented on issue #10223:
URL: https://github.com/apache/airflow/issues/10223#issuecomment-670623678


   Indeed!  Didn't scroll down.  Thanks!
   Closing this ticket.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] fengsi closed issue #10223: Airflow configuration in web UI should recognize current settings rather than reading from `AIRFLOW_CONFIG` file

Posted by GitBox <gi...@apache.org>.
fengsi closed issue #10223:
URL: https://github.com/apache/airflow/issues/10223


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on issue #10223: Airflow configuration in web UI should recognize current settings rather than reading from `AIRFLOW_CONFIG` file

Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #10223:
URL: https://github.com/apache/airflow/issues/10223#issuecomment-670602035


   They are reflect. There are 2 configurations on the UI:
   
   1) Configs from airflow.cfg
   2) Running Configuration


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on issue #10223: Airflow configuration in web UI should recognize current settings rather than reading from `AIRFLOW_CONFIG` file

Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #10223:
URL: https://github.com/apache/airflow/issues/10223#issuecomment-670602403


   Check https://github.com/apache/airflow/blob/44d4ae809c1e3784ff95b6a5e95113c3412e56b3/airflow/www/templates/airflow/config.html#L44-L67


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org