[jira] [Commented] (AIRFLOW-5153) Add option to force delete a non-empty Google BQ dataset

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16903872#comment-16903872 ] 

ASF GitHub Bot commented on AIRFLOW-5153:
-----------------------------------------

mohannadbanayosi commented on pull request #5768: [AIRFLOW-5153] Option to force delete non-empty BQ datasets
URL: https://github.com/apache/airflow/pull/5768
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-5153) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5153
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   This extra bool argument gives the option to delete a non-empty Google BigQuery dataset as well as its tables.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add option to force delete a non-empty Google BQ dataset
> --------------------------------------------------------
>
>                 Key: AIRFLOW-5153
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5153
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: contrib
>    Affects Versions: 1.10.3
>            Reporter: Mohannad Albanayosy
>            Assignee: Mohannad Albanayosy
>            Priority: Minor
>
> h2. Problem
> There is currently no option to force delete a Google BigQuery dataset that is not empty along with its tables.
> h2. Proposed improvement
> Add _delete_contents_ as an extra argument to the _BigQueryDeleteDatasetOperator_ to specify whether to force the deletion (even if the dataset is not empty) or not. Update the _BigQueryBaseCursor_ too.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)