[GitHub] [incubator-pinot] snleee commented on a change in pull request #4320: Add deprecated annotation for segment & segment zk metadata

[GitBox <gi...@apache.org>]

snleee commented on a change in pull request #4320: Add deprecated annotation for segment & segment zk metadata
URL: https://github.com/apache/incubator-pinot/pull/4320#discussion_r294014385
 
 

 ##########
 File path: pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
 ##########
 @@ -360,6 +359,9 @@ public ServerType getServerType() {
     public enum SegmentType {
       OFFLINE, REALTIME
     }
+
+    @Deprecated
+    public static final String TABLE_NAME = "segment.table.name";
 
 Review comment:
   The only current usage of table name from `SegmentMetadataImpl` is when deriving a table name from segment metadata during segment upload. Eventually, I would like to replace this with table name header from upload.
   
   The reason why I want to put deprecated annotation now is to prevent people from using it anywhere else. How do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org