You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/18 14:22:15 UTC
[GitHub] [cloudstack] GutoVeronezi opened a new pull request #4706: Improve logs on KVMHostActivityChecker
GutoVeronezi opened a new pull request #4706:
URL: https://github.com/apache/cloudstack/pull/4706
### Description
This PR intends to improve logging in the class `KVMHostActivityChecker` to facilitate troubleshooting.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functioanlity)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
### How Has This Been Tested?
It has been tested locally on a test lab.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4706: Improve logs on KVMHostActivityChecker
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4706:
URL: https://github.com/apache/cloudstack/pull/4706#issuecomment-781563667
> Overall code looks good; most of the changes regard adding logs while keeping the core behavior of the execution flow.
>
> I would like just to bring another option to enhance the logs: what do you think of adding the host's name combined (or not) with the host ID?
>
> In my opinion, this would make it easier to find the problematic host in a blink of an eye, otherwise, there is the need of checking via DB/API to find which host has the respective ID.
@GabrielBrascher as you suggested, I added more host information to the log.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4706: Improve logs on KVMHostActivityChecker
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4706:
URL: https://github.com/apache/cloudstack/pull/4706#issuecomment-817004431
<b>Trillian test result (tid-393)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49324 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4706-t393-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 86 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_deploy_kubernetes_cluster | `Failure` | 3610.68 | test_kubernetes_clusters.py
test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 41.93 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 3616.17 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 49.03 | test_kubernetes_clusters.py
test_01_migrate_VM_and_root_volume | `Error` | 69.33 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 52.23 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4706: Improve logs on KVMHostActivityChecker
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4706:
URL: https://github.com/apache/cloudstack/pull/4706#issuecomment-816483451
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #4706: Improve logs on KVMHostActivityChecker
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #4706:
URL: https://github.com/apache/cloudstack/pull/4706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4706: Improve logs on KVMHostActivityChecker
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4706:
URL: https://github.com/apache/cloudstack/pull/4706#issuecomment-781392256
pressed enter by accident ^^
code LGTM not tested
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #4706: Improve logs on KVMHostActivityChecker
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #4706:
URL: https://github.com/apache/cloudstack/pull/4706#issuecomment-816659039
This one looks ready for merge. Travis and Jenkins's tests have passed and the code has 2 LGTMs. Maybe we can spawn @blueorangutan for testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4706: Improve logs on KVMHostActivityChecker
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4706:
URL: https://github.com/apache/cloudstack/pull/4706#issuecomment-814912498
@GabrielBrascher @DaanHoogland is there anything else to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org