You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/06/02 20:38:18 UTC

[GitHub] [activemq-artemis] jbertram commented on pull request #4102: Update ActiveMQServerImpl.java

jbertram commented on PR #4102:
URL: https://github.com/apache/activemq-artemis/pull/4102#issuecomment-1145319072

   This really needs a test to validate the fix and also to ensure there are no regressions in the future.
   
   Basic tests for resource limits are at `org.apache.activemq.artemis.tests.integration.server.ResourceLimitTest`. A test using certificates is at `org.apache.activemq.artemis.tests.integration.security.SecurityTest#testJAASSecurityManagerAuthenticationWithCerts()`. Take bits and pieces from both and create a new class `org.apache.activemq.artemis.tests.integration.server.ResourceLimitTestWithCerts`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org