You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@syncope.apache.org by il...@apache.org on 2020/02/14 07:42:04 UTC
[syncope] branch master updated: [SYNCOPE-1542] Always lookup
groups from root realm
This is an automated email from the ASF dual-hosted git repository.
ilgrosso pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/syncope.git
The following commit(s) were added to refs/heads/master by this push:
new f057013 [SYNCOPE-1542] Always lookup groups from root realm
f057013 is described below
commit f057013572f20bccc9732aa0bdb4ca737bb6c55b
Author: Francesco Chicchiriccò <il...@apache.org>
AuthorDate: Fri Feb 14 08:37:50 2020 +0100
[SYNCOPE-1542] Always lookup groups from root realm
---
.../org/apache/syncope/client/console/panels/AnyPanel.java | 6 +++---
.../client/console/panels/search/AbstractSearchPanel.java | 11 -----------
.../client/console/panels/search/AnyObjectSearchPanel.java | 3 ++-
.../client/console/panels/search/SearchClausePanel.java | 9 +++------
4 files changed, 8 insertions(+), 21 deletions(-)
diff --git a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/AnyPanel.java b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/AnyPanel.java
index bf0d26c..799e8e0 100644
--- a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/AnyPanel.java
+++ b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/AnyPanel.java
@@ -319,7 +319,7 @@ public class AnyPanel extends Panel implements ModalPanel {
clause.setProperty("username");
panel = new UserSearchPanel.Builder(
- new ListModel<>(clauses)).realm(realmTO.getFullPath()).required(true).enableSearch().build(id);
+ new ListModel<>(clauses)).required(true).enableSearch().build(id);
break;
case GROUP:
@@ -328,7 +328,7 @@ public class AnyPanel extends Panel implements ModalPanel {
clause.setProperty("name");
panel = new GroupSearchPanel.Builder(
- new ListModel<>(clauses)).realm(realmTO.getFullPath()).required(true).enableSearch().build(id);
+ new ListModel<>(clauses)).required(true).enableSearch().build(id);
break;
case ANY_OBJECT:
@@ -337,7 +337,7 @@ public class AnyPanel extends Panel implements ModalPanel {
clause.setProperty("name");
panel = new AnyObjectSearchPanel.Builder(anyTypeTO.getKey(),
- new ListModel<>(clauses)).realm(realmTO.getFullPath()).required(true).enableSearch().build(id);
+ new ListModel<>(clauses)).required(true).enableSearch().build(id);
break;
default:
diff --git a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/search/AbstractSearchPanel.java b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/search/AbstractSearchPanel.java
index b3cc3d2b..d1c6c50 100644
--- a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/search/AbstractSearchPanel.java
+++ b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/search/AbstractSearchPanel.java
@@ -64,8 +64,6 @@ public abstract class AbstractSearchPanel extends Panel {
protected WebMarkupContainer searchFormContainer;
- protected final String realm;
-
protected final AnyTypeKind typeKind;
protected final String type;
@@ -82,8 +80,6 @@ public abstract class AbstractSearchPanel extends Panel {
protected final IModel<List<SearchClause>> model;
- protected String realm = SyncopeConstants.ROOT_REALM;
-
protected boolean required = true;
protected boolean enableSearch = false;
@@ -100,11 +96,6 @@ public abstract class AbstractSearchPanel extends Panel {
this.model = model;
}
- public Builder<T> realm(final String realm) {
- this.realm = realm;
- return this;
- }
-
public Builder<T> enableSearch(final IEventSink resultContainer) {
this.resultContainer = resultContainer;
return enableSearch();
@@ -143,7 +134,6 @@ public abstract class AbstractSearchPanel extends Panel {
: Pair.of(groupNames, 0);
this.model = builder.model;
- this.realm = builder.realm;
this.typeKind = kind;
this.type = type;
this.required = builder.required;
@@ -157,7 +147,6 @@ public abstract class AbstractSearchPanel extends Panel {
SearchClausePanel searchClausePanel = new SearchClausePanel("panel", "panel",
Model.of(new SearchClause()),
- realm,
required,
types,
builder.customizer,
diff --git a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/search/AnyObjectSearchPanel.java b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/search/AnyObjectSearchPanel.java
index e371ca7..530191c 100644
--- a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/search/AnyObjectSearchPanel.java
+++ b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/search/AnyObjectSearchPanel.java
@@ -26,6 +26,7 @@ import java.util.stream.Collectors;
import org.apache.syncope.client.console.rest.AnyTypeRestClient;
import org.apache.syncope.client.console.rest.SchemaRestClient;
import org.apache.syncope.client.ui.commons.Constants;
+import org.apache.syncope.common.lib.SyncopeConstants;
import org.apache.syncope.common.lib.to.GroupTO;
import org.apache.syncope.common.lib.to.PlainSchemaTO;
import org.apache.syncope.common.lib.types.AnyTypeKind;
@@ -84,7 +85,7 @@ public class AnyObjectSearchPanel extends AbstractSearchPanel {
@Override
protected List<String> load() {
return groupRestClient.search(
- realm,
+ SyncopeConstants.ROOT_REALM,
null,
1,
Constants.MAX_GROUP_LIST_SIZE,
diff --git a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/search/SearchClausePanel.java b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/search/SearchClausePanel.java
index 1153467..f1c4542 100644
--- a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/search/SearchClausePanel.java
+++ b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/search/SearchClausePanel.java
@@ -42,6 +42,7 @@ import org.apache.syncope.client.ui.commons.markup.html.form.AjaxDropDownChoiceP
import org.apache.syncope.client.ui.commons.markup.html.form.AjaxTextFieldPanel;
import org.apache.syncope.client.ui.commons.markup.html.form.FieldPanel;
import org.apache.syncope.client.lib.SyncopeClient;
+import org.apache.syncope.common.lib.SyncopeConstants;
import org.apache.syncope.common.lib.to.GroupTO;
import org.apache.syncope.common.lib.to.PlainSchemaTO;
import org.apache.syncope.common.lib.to.RelationshipTypeTO;
@@ -124,8 +125,6 @@ public class SearchClausePanel extends FieldPanel<SearchClause> {
}
}
- private final String realm;
-
private final boolean required;
private final IModel<List<SearchClause.Type>> types;
@@ -164,7 +163,6 @@ public class SearchClausePanel extends FieldPanel<SearchClause> {
final String id,
final String name,
final Model<SearchClause> clause,
- final String realm,
final boolean required,
final IModel<List<SearchClause.Type>> types,
final Customizer customizer,
@@ -179,7 +177,6 @@ public class SearchClausePanel extends FieldPanel<SearchClause> {
this.clause = clause == null ? new Model<>(null) : clause;
- this.realm = realm;
this.required = required;
this.types = types;
this.customizer = customizer;
@@ -450,7 +447,7 @@ public class SearchClausePanel extends FieldPanel<SearchClause> {
inputValue = inputValue + "*";
}
property.setChoices(groupRestClient.search(
- realm,
+ SyncopeConstants.ROOT_REALM,
SyncopeClient.getGroupSearchConditionBuilder().
is("name").equalToIgnoreCase(inputValue).
query(),
@@ -886,7 +883,7 @@ public class SearchClausePanel extends FieldPanel<SearchClause> {
@Override
public FieldPanel<SearchClause> clone() {
SearchClausePanel panel = new SearchClausePanel(
- getId(), name, null, realm, required, types, customizer, anames, dnames, groupInfo,
+ getId(), name, null, required, types, customizer, anames, dnames, groupInfo,
roleNames, privilegeNames, resourceNames);
panel.setReadOnly(this.isReadOnly());
panel.setRequired(this.isRequired());