You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/10/15 16:12:46 UTC
[GitHub] [netbeans] entlicher opened a new pull request #2459: Propagate a launch error to the client.
entlicher opened a new pull request #2459:
URL: https://github.com/apache/netbeans/pull/2459
This change assures that an error during launch is propagated to the client.
The ResponseError's message is displayed in an error dialog in VSCode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] entlicher merged pull request #2459: Propagate a launch error to the client.
Posted by GitBox <gi...@apache.org>.
entlicher merged pull request #2459:
URL: https://github.com/apache/netbeans/pull/2459
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2459: Propagate a launch error to the client.
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2459:
URL: https://github.com/apache/netbeans/pull/2459#discussion_r505710302
##########
File path: java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/debugging/launch/NbLaunchDelegate.java
##########
@@ -63,7 +63,9 @@
Pair<ActionProvider, String> providerAndCommand = findTarget(toRun, debug);
CompletableFuture<Void> launchFuture = new CompletableFuture<>();
if (providerAndCommand == null) {
- launchFuture.completeExceptionally(new CancellationException("Cannot find " + (debug ? "debug" : "run") + " action!"));
+ launchFuture.completeExceptionally(new ResponseErrorException(new ResponseError(
Review comment:
Good idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists