You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@celeborn.apache.org by "onebox-li (via GitHub)" <gi...@apache.org> on 2023/10/20 13:02:39 UTC

Re: [PR] [WIP][CELEBORN-1059] Fix callback not update if push worker excluded during retry [incubator-celeborn]

onebox-li commented on PR #2005:
URL: https://github.com/apache/incubator-celeborn/pull/2005#issuecomment-1772701828

   The `RetryReviveTest` UT can always revive succeed because of the partition location's epoch not updated when retry. If do the update there(IMO this is correct rather than before one), LifeCycleManager will exclude the worker when revive in the original behavior. Finally the test will fail because of REVIVE_FAILED(SLOT_NOT_AVAILABLE). So here let LifeCycleManager doesn't exclude workers when test revive to avoid randomness in small test clusters.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org