You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by "Michael Osipov (JIRA)" <ji...@apache.org> on 2019/07/10 07:49:00 UTC

[jira] [Commented] (MNG-6704) MavenRepositorySystemUtils.newSession() unnecessary code

    [ https://issues.apache.org/jira/browse/MNG-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16881804#comment-16881804 ] 

Michael Osipov commented on MNG-6704:
-------------------------------------

May this be a bug? I assume that the `ChainedDependencyGraphTransformer` should go to `setDependencyGraphTransformer()`. [~rfscholte], WDYT?

> MavenRepositorySystemUtils.newSession()  unnecessary code
> ---------------------------------------------------------
>
>                 Key: MNG-6704
>                 URL: https://issues.apache.org/jira/browse/MNG-6704
>             Project: Maven
>          Issue Type: Improvement
>            Reporter: guofei
>            Priority: Trivial
>
> `new ChainedDependencyGraphTransformer` seems make no sense here.
> {code:java}
> public static DefaultRepositorySystemSession newSession()
> {
> // ...
> DependencyGraphTransformer transformer =
> new ConflictResolver( new NearestVersionSelector(), new JavaScopeSelector(),
> new SimpleOptionalitySelector(), new JavaScopeDeriver() );
> // seems unnecessary
> new ChainedDependencyGraphTransformer( transformer, new JavaDependencyContextRefiner() );
> session.setDependencyGraphTransformer( transformer );
> // ...
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)