[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #686: GEODE-8688: Fix flaky C++ native client integration tests

[GitBox <gi...@apache.org>]

pivotal-jbarrett commented on a change in pull request #686:
URL: https://github.com/apache/geode-native/pull/686#discussion_r518456823



##########
File path: cppcache/integration/test/PartitionRegionOpsTest.cpp
##########
@@ -144,6 +146,10 @@ void verifyMetadataWasRemovedAtFirstError() {
       }
     }
   }
+  std::cout << "timeoutErrors: " << timeoutErrors << ", ioErrors: " << ioErrors
+            << ", metadataRemovedDueToTimeout: " << metadataRemovedDueToTimeout
+            << ", metadataRemovedDueToIoErr: " << metadataRemovedDueToIoErr
+            << std::endl;

Review comment:
       Tests should never output anything other than assertion failures. If more information is useful to log then it is useful to assert.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org