[GitHub] cordova-plugin-media pull request: Cordova-Android 5.0/Marshmallow...

[nikhilkh <gi...@git.apache.org>]

Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-media/pull/71#discussion_r41170559
  
    --- Diff: src/android/AudioHandler.java ---
    @@ -55,6 +59,16 @@ Licensed to the Apache Software Foundation (ASF) under one
         private int origVolumeStream = -1;
         private CallbackContext messageChannel;
     
    +
    +    public static String [] permissions = { Manifest.permission.RECORD_AUDIO, Manifest.permission.WRITE_EXTERNAL_STORAGE};
    +    public static int RECORD_AUDIO = 0;
    +    public static int WRITE_EXTERNAL_STORAGE = 1;
    +
    +    public static final int PERMISSION_DENIED_ERROR = 20;
    --- End diff --
    
    Does the magic number need to be documented? I'm not very familiar with error handling and how Cordova deals with error codes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org