You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/08 16:19:32 UTC
[GitHub] [airflow] ryanahamilton opened a new pull request #12923: Fix: Use "auto" instead of "scroll" to prevent visible (unused) scrollbars
ryanahamilton opened a new pull request #12923:
URL: https://github.com/apache/airflow/pull/12923
Firefox on Linux displays scrollbars even when there isn't overflow occurring to make use of them. Changing `scroll` to `auto` will hide these until they are needed (overflow occurs). This behavior will be consistent with the way most other browsers already treat `scroll` and `auto`. I updated all instances in all CSS files.
CC: @ashb the Firefox on Linux user that brought these to my attention.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton merged pull request #12923: Fix: Use "auto" instead of "scroll" to prevent visible (unused) scrollbars
Posted by GitBox <gi...@apache.org>.
ryanahamilton merged pull request #12923:
URL: https://github.com/apache/airflow/pull/12923
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on pull request #12923: Fix: Use "auto" instead of "scroll" to prevent visible (unused) scrollbars
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on pull request #12923:
URL: https://github.com/apache/airflow/pull/12923#issuecomment-740809744
@ashb ha, I know you're not the only snowflake!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #12923: Fix: Use "auto" instead of "scroll" to prevent visible (unused) scrollbars
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #12923:
URL: https://github.com/apache/airflow/pull/12923#issuecomment-740808140
> CC: @ashb the Firefox on Linux user that brought these to my attention.
Hey! You say that like I'm the only one. I'll have you know there are at _least_ four of us in the world.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12923: Fix: Use "auto" instead of "scroll" to prevent visible (unused) scrollbars
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12923:
URL: https://github.com/apache/airflow/pull/12923#issuecomment-740740766
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org