You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2011/01/06 03:33:45 UTC

[jira] Created: (HTTPCLIENT-1040) .NTLMEngineImpl.MD4.update() - dead store to curBufferPos @ line 1103

.NTLMEngineImpl.MD4.update() - dead store to curBufferPos @ line 1103
---------------------------------------------------------------------

                 Key: HTTPCLIENT-1040
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1040
             Project: HttpComponents HttpClient
          Issue Type: Bug
          Components: HttpClient
            Reporter: Sebb
            Priority: Minor


Line 1103 has:

curBufferPos += transferAmt;

however the local variable is not used after that point.

This could be indicative of a bug.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] Updated: (HTTPCLIENT-1040) .NTLMEngineImpl.MD4.update() - dead store to curBufferPos @ line 1103

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski updated HTTPCLIENT-1040:
------------------------------------------

      Component/s:     (was: HttpClient)
                   HttpAuth
    Fix Version/s: Future

> .NTLMEngineImpl.MD4.update() - dead store to curBufferPos @ line 1103
> ---------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1040
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1040
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpAuth
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: Future
>
>
> Line 1103 has:
> curBufferPos += transferAmt;
> however the local variable is not used after that point.
> This could be indicative of a bug.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] [Commented] (HTTPCLIENT-1040) .NTLMEngineImpl.MD4.update() - dead store to curBufferPos @ line 1103

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510467#comment-13510467 ] 

Oleg Kalnichevski commented on HTTPCLIENT-1040:
-----------------------------------------------

Not at all. It is all yours. Moreover, I have HC committership to go with it, if you are interested ;-)

Oleg  
                
> .NTLMEngineImpl.MD4.update() - dead store to curBufferPos @ line 1103
> ---------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1040
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1040
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpAuth
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: Future
>
>
> Line 1103 has:
> curBufferPos += transferAmt;
> however the local variable is not used after that point.
> This could be indicative of a bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] [Updated] (HTTPCLIENT-1040) .NTLMEngineImpl.MD4.update() - dead store to curBufferPos @ line 1103

Posted by "Karl Wright (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Karl Wright updated HTTPCLIENT-1040:
------------------------------------

    Attachment: HTTPCLIENT-1040.patch

Patch to comment out dead code line

                
> .NTLMEngineImpl.MD4.update() - dead store to curBufferPos @ line 1103
> ---------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1040
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1040
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpAuth
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: Future
>
>         Attachments: HTTPCLIENT-1040.patch
>
>
> Line 1103 has:
> curBufferPos += transferAmt;
> however the local variable is not used after that point.
> This could be indicative of a bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] [Commented] (HTTPCLIENT-1040) .NTLMEngineImpl.MD4.update() - dead store to curBufferPos @ line 1103

Posted by "Karl Wright (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510360#comment-13510360 ] 

Karl Wright commented on HTTPCLIENT-1040:
-----------------------------------------

This is not an issue and does not represent anything other than an inefficiency; the MD4 hash is tested with the NTLMTest and works.

                
> .NTLMEngineImpl.MD4.update() - dead store to curBufferPos @ line 1103
> ---------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1040
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1040
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpAuth
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: Future
>
>
> Line 1103 has:
> curBufferPos += transferAmt;
> however the local variable is not used after that point.
> This could be indicative of a bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] [Commented] (HTTPCLIENT-1040) .NTLMEngineImpl.MD4.update() - dead store to curBufferPos @ line 1103

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510459#comment-13510459 ] 

Oleg Kalnichevski commented on HTTPCLIENT-1040:
-----------------------------------------------

Can we then remove or comment out this line?

Oleg
                
> .NTLMEngineImpl.MD4.update() - dead store to curBufferPos @ line 1103
> ---------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1040
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1040
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpAuth
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: Future
>
>
> Line 1103 has:
> curBufferPos += transferAmt;
> however the local variable is not used after that point.
> This could be indicative of a bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] [Commented] (HTTPCLIENT-1040) .NTLMEngineImpl.MD4.update() - dead store to curBufferPos @ line 1103

Posted by "Karl Wright (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510470#comment-13510470 ] 

Karl Wright commented on HTTPCLIENT-1040:
-----------------------------------------

I would be happy to accept a committership. ;-)  Should be straightforward since all my Apache forms are already on record.

                
> .NTLMEngineImpl.MD4.update() - dead store to curBufferPos @ line 1103
> ---------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1040
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1040
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpAuth
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: Future
>
>
> Line 1103 has:
> curBufferPos += transferAmt;
> however the local variable is not used after that point.
> This could be indicative of a bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] [Commented] (HTTPCLIENT-1040) .NTLMEngineImpl.MD4.update() - dead store to curBufferPos @ line 1103

Posted by "Karl Wright (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510461#comment-13510461 ] 

Karl Wright commented on HTTPCLIENT-1040:
-----------------------------------------

Yes, I will submit that change later today, unless you'd like to do it yourself. ;-)

                
> .NTLMEngineImpl.MD4.update() - dead store to curBufferPos @ line 1103
> ---------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1040
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1040
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpAuth
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: Future
>
>
> Line 1103 has:
> curBufferPos += transferAmt;
> however the local variable is not used after that point.
> This could be indicative of a bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org