You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by PramodSSImmaneni <gi...@git.apache.org> on 2016/03/17 19:13:08 UTC
[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2017 Use pre checkp...
GitHub user PramodSSImmaneni opened a pull request:
https://github.com/apache/incubator-apex-malhar/pull/218
APEXMALHAR-2017 Use pre checkpoint notification to optimize operator IO
@chandnisingh @siyuanh @DT-Priyanka please review as it touches many operators
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PramodSSImmaneni/incubator-apex-malhar before-checkpoint
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-malhar/pull/218.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #218
----
commit 0339e2cea68b6c10b6082a1c9bbd5bd293ef8612
Author: Pramod Immaneni <pr...@datatorrent.com>
Date: 2016-03-17T03:57:39Z
Using CheckpointNotificationListener and beforeCheckpoint callback to do IO in a more optimized fashion
commit 3599abbba304f7ab7fa333484ca701d817625c24
Author: Pramod Immaneni <pr...@datatorrent.com>
Date: 2016-03-17T17:21:07Z
Fixed fileoutput operator failing tests
commit ae1c2eabb64382af5e20f905112a7d67b7fe80e1
Author: Pramod Immaneni <pr...@datatorrent.com>
Date: 2016-03-17T17:42:45Z
Fixes for japicmp
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: APEXMALHAR-2017 Use pre checkp...
Posted by chandnisingh <gi...@git.apache.org>.
Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/218#discussion_r57111096
--- Diff: library/src/main/java/com/datatorrent/lib/io/fs/AbstractFileOutputOperator.java ---
@@ -1195,6 +1188,24 @@ public void close() throws IOException
}
@Override
+ public void beforeCheckpoint(long l)
+ {
+ try {
+ Map<String, FSFilterStreamContext> openStreams = streamsCache.asMap();
+ for (FSFilterStreamContext streamContext: openStreams.values()) {
+ long start = System.currentTimeMillis();
+ streamContext.finalizeContext();
+ totalWritingTime += System.currentTimeMillis() - start;
+ //streamContext.resetFilter();
--- End diff --
why this commented out code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---