[GitHub] [helix] xyuanlu commented on a diff in pull request #2335: MetaClient - Implementation of Create from CRUD operations

[GitBox <gi...@apache.org>]

xyuanlu commented on code in PR #2335:
URL: https://github.com/apache/helix/pull/2335#discussion_r1067373919


##########
meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java:
##########
@@ -70,11 +90,22 @@ public Object update(String key, DataUpdater updater) {
 
   @Override
   public Stat exists(String key) {
-    return null;
-  }
-
-  @Override
-  public Object get(String key) {
+    org.apache.zookeeper.data.Stat zkStats;

Review Comment:
   Please mark here as temp impl for test only.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org