You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by r-kamath <gi...@git.apache.org> on 2018/06/01 09:56:17 UTC

[GitHub] zeppelin pull request #2996: ZEPPELIN-3521 Dynamic note form overlaps with p...

GitHub user r-kamath opened a pull request:

    https://github.com/apache/zeppelin/pull/2996

    ZEPPELIN-3521 Dynamic note form overlaps with paragraph content in iframe page ("Link this paragraph")

    ### What is this PR for?
    Dynamic note form overlaps with paragraph content in iframe page ("Link this paragraph")
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-3521
    
    ### How should this be tested?
    Click on "Link this paragraph" from the paragraph menu to get paragraph in iframe mode
    
    ### Screenshots (if appropriate)
    ***Before***
    <img width="755" alt="before" src="https://user-images.githubusercontent.com/2031306/40834926-c3783e22-65af-11e8-9ff1-39cb0ece60ff.png">
    ***After***
    <img width="881" alt="after" src="https://user-images.githubusercontent.com/2031306/40834928-c4c43a1a-65af-11e8-947d-093cfcde38ef.png">
    
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/r-kamath/zeppelin ZEPPELIN-3521

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2996.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2996
    
----
commit 207a0d3634412605fb1db88f435743f9b570b6d3
Author: Renjith Kamath <rk...@...>
Date:   2018-06-01T09:54:59Z

    ZEPPELIN-3521 Dynamic note form overlaps with paragraph content in iframe page ("Link this paragraph")
    
    Change-Id: I187a23f8bd88b724ef6c9a37f2bde248034b75c1

----


---

[GitHub] zeppelin issue #2996: ZEPPELIN-3521 Dynamic note form overlaps with paragrap...

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2996
  
    LGTM!
    Merging this to master and branch-0.8 if no more discussion.


---

[GitHub] zeppelin issue #2996: ZEPPELIN-3521 Dynamic note form overlaps with paragrap...

Posted by mebelousov <gi...@git.apache.org>.

Github user mebelousov commented on the issue:

    https://github.com/apache/zeppelin/pull/2996
  
    LGTM


---

[GitHub] zeppelin pull request #2996: ZEPPELIN-3521 Dynamic note form overlaps with p...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2996


---

[GitHub] zeppelin issue #2996: ZEPPELIN-3521 Dynamic note form overlaps with paragrap...

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2996
  
    LGTM


---

[GitHub] zeppelin issue #2996: ZEPPELIN-3521 Dynamic note form overlaps with paragrap...

Posted by r-kamath <gi...@git.apache.org>.

Github user r-kamath commented on the issue:

    https://github.com/apache/zeppelin/pull/2996
  
    @mebelousov @prabhjyotsingh please review


---