[jira] [Resolved] (BEAM-408) ProxyInvocationHandler uses inefficient Math.random() for random int

["Luke Cwik (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Luke Cwik resolved BEAM-408.
----------------------------
       Resolution: Fixed
    Fix Version/s: 0.2.0-incubating

> ProxyInvocationHandler uses inefficient Math.random() for random int
> --------------------------------------------------------------------
>
>                 Key: BEAM-408
>                 URL: https://issues.apache.org/jira/browse/BEAM-408
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Scott Wegner
>            Assignee: Lucas Amorim
>            Priority: Minor
>              Labels: findbugs, newbie, starter
>             Fix For: 0.2.0-incubating
>
>
> [FindBugs DM_NEXTINT_VIA_NEXTDOUBLE|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L209]: Use the nextInt method of Random rather than nextDouble to generate a random integer
> Applies to: [ProxyInvocationHandler.hashCode|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/options/ProxyInvocationHandler.java#L96]. This random value is used as a pseudo-unique value for #hashCode(), although the default Object.hasCode() implementation does the same thing, so this should be unnecessary.
> This is a good starter bug. When fixing, please remove the corresponding entries from [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] and verify the build passes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)