You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "1996fanrui (via GitHub)" <gi...@apache.org> on 2026/03/18 16:38:51 UTC
[PR] [FLINK-38541][checkpoint] Introducing config option: execution.checkpointing.unaligned.during-recovery.enabled [flink]
1996fanrui opened a new pull request, #27782:
URL: https://github.com/apache/flink/pull/27782
## What is the purpose of the change
Introducing config option: `execution.checkpointing.unaligned.during-recovery.enabled`, and some refactors.
## Brief change log
- [hotfix][runtime] Extract RecordFilter as the interface
- [hotfix] Extract VirtualChannel as the public class
- [FLINK-38541][checkpoint] Introducing config option: execution.checkpointing.unaligned.during-recovery.enabled
- [FLINK-38541][checkpoint] Randomize `UNALIGNED_DURING_RECOVERY_ENABLED` for testing
## Verifying this change
- Introduced RecordFilterTest
- Added tests for CheckpointingOptionsTest
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? JavaDocs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38541][checkpoint] Introducing config option: execution.checkpointing.unaligned.during-recovery.enabled [flink]
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui merged PR #27782:
URL: https://github.com/apache/flink/pull/27782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38541][checkpoint] Introducing config option: execution.checkpointing.unaligned.during-recovery.enabled [flink]
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on code in PR #27782:
URL: https://github.com/apache/flink/pull/27782#discussion_r2974678387
##########
flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java:
##########
@@ -668,6 +669,40 @@ public class CheckpointingOptions {
"Whether recovering output buffers of upstream task on downstream task directly "
+ "when job restores from the unaligned checkpoint.");
+ /**
+ * Whether to enable checkpointing during recovery from an unaligned checkpoint.
+ *
+ * <p>When enabled, the job can take checkpoints while still recovering channel state (inflight
+ * data) from a previous unaligned checkpoint. This avoids the need to wait for full recovery
+ * before the first checkpoint can be triggered, which reduces the window of vulnerability to
+ * failures during recovery.
+ *
+ * <p>This option requires {@link #UNALIGNED_RECOVER_OUTPUT_ON_DOWNSTREAM} to be enabled. It
+ * does not require unaligned checkpoints to be currently enabled, because a job may restore
+ * from an unaligned checkpoint while having unaligned checkpoints disabled for the new
+ * execution.
+ */
Review Comment:
Thanks, both are merged into description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38541][checkpoint] Introducing config option: execution.checkpointing.unaligned.during-recovery.enabled [flink]
Posted by "pnowojski (via GitHub)" <gi...@apache.org>.
pnowojski commented on code in PR #27782:
URL: https://github.com/apache/flink/pull/27782#discussion_r2974141654
##########
flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java:
##########
@@ -668,6 +669,40 @@ public class CheckpointingOptions {
"Whether recovering output buffers of upstream task on downstream task directly "
+ "when job restores from the unaligned checkpoint.");
+ /**
+ * Whether to enable checkpointing during recovery from an unaligned checkpoint.
+ *
+ * <p>When enabled, the job can take checkpoints while still recovering channel state (inflight
+ * data) from a previous unaligned checkpoint. This avoids the need to wait for full recovery
+ * before the first checkpoint can be triggered, which reduces the window of vulnerability to
+ * failures during recovery.
+ *
+ * <p>This option requires {@link #UNALIGNED_RECOVER_OUTPUT_ON_DOWNSTREAM} to be enabled. It
+ * does not require unaligned checkpoints to be currently enabled, because a job may restore
+ * from an unaligned checkpoint while having unaligned checkpoints disabled for the new
+ * execution.
+ */
Review Comment:
nit: shouldn't this be copied into the description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38541][checkpoint] Introducing config option: execution.checkpointing.unaligned.during-recovery.enabled [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #27782:
URL: https://github.com/apache/flink/pull/27782#issuecomment-4084025389
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0aa07d8799e5a9896a3addaecccc136556211d73",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0aa07d8799e5a9896a3addaecccc136556211d73",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0aa07d8799e5a9896a3addaecccc136556211d73 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org