You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by sk...@apache.org on 2022/08/08 15:40:34 UTC
[ignite-3] branch main updated: IGNITE-14843 Updated obsolete TODOs
This is an automated email from the ASF dual-hosted git repository.
sk0x50 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
The following commit(s) were added to refs/heads/main by this push:
new b92858cb8 IGNITE-14843 Updated obsolete TODOs
b92858cb8 is described below
commit b92858cb8cd263751724ca259fca061f630035df
Author: Slava Koptilin <sl...@gmail.com>
AuthorDate: Mon Aug 8 18:40:19 2022 +0300
IGNITE-14843 Updated obsolete TODOs
---
.../src/main/java/org/apache/ignite/raft/jraft/core/Replicator.java | 4 +++-
.../apache/ignite/raft/jraft/rpc/impl/AbstractClientService.java | 6 +++++-
.../java/org/apache/ignite/raft/jraft/rpc/impl/IgniteRpcServer.java | 4 +++-
3 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/Replicator.java b/modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/Replicator.java
index abc52e22a..2e7cd54ad 100644
--- a/modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/Replicator.java
+++ b/modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/Replicator.java
@@ -1119,7 +1119,9 @@ public class Replicator implements ThreadId.OnError {
LOG.warn("Fail to issue RPC to {}, consecutiveErrorTimes={}, error={}", r.options.getPeerId(),
r.consecutiveErrorTimes, status);
}
- r.startHeartbeatTimer(startTimeMs); // TODO asch use discovery instead of constant probing IGNITE-14843
+ // TODO https://issues.apache.org/jira/browse/IGNITE-14837
+ // Consider using discovery instead of constant probing.
+ r.startHeartbeatTimer(startTimeMs);
return;
}
r.consecutiveErrorTimes = 0;
diff --git a/modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/impl/AbstractClientService.java b/modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/impl/AbstractClientService.java
index b8cbabc41..5d875983a 100644
--- a/modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/impl/AbstractClientService.java
+++ b/modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/impl/AbstractClientService.java
@@ -73,7 +73,11 @@ public abstract class AbstractClientService implements ClientService, TopologyEv
}
@Override public void onAppeared(ClusterNode member) {
- // No-op. TODO asch https://issues.apache.org/jira/browse/IGNITE-14843
+ // TODO https://issues.apache.org/jira/browse/IGNITE-14837
+ // Perhaps, We can remove checking for dead nodes and replace it with SWIM node alive event
+ // and start replicator when the event is received.
+
+ // No-op.
}
@Override public void onDisappeared(ClusterNode member) {
diff --git a/modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/impl/IgniteRpcServer.java b/modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/impl/IgniteRpcServer.java
index 9ef0eeb0a..089f96488 100644
--- a/modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/impl/IgniteRpcServer.java
+++ b/modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/impl/IgniteRpcServer.java
@@ -124,7 +124,9 @@ public class IgniteRpcServer implements RpcServer<Void> {
service.topologyService().addEventHandler(new TopologyEventHandler() {
@Override public void onAppeared(ClusterNode member) {
- // TODO asch optimize start replicator https://issues.apache.org/jira/browse/IGNITE-14843
+ // TODO https://issues.apache.org/jira/browse/IGNITE-14837
+ // Perhaps, We can remove checking for dead nodes and replace it with SWIM node alive event
+ // and start replicator when the event is received.
}
@Override public void onDisappeared(ClusterNode member) {