You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by "royfengsss (via GitHub)" <gi...@apache.org> on 2023/09/14 09:12:19 UTC

[GitHub] [nuttx] royfengsss commented on a diff in pull request #10626: esp32: Use newlib-esp32

royfengsss commented on code in PR #10626:
URL: https://github.com/apache/nuttx/pull/10626#discussion_r1325640967


##########
libs/libm/newlib/Make.defs:
##########
@@ -18,21 +18,31 @@
 #
 ############################################################################
 
-NEWLIB_VERSION=4.3.0.20230120
+ifeq ($(CONFIG_LIBM_USE_NEWLIB_ESP32),y)
+  NEWLIB_VERSION=esp-4.1.0_20230425
+  NEWLIB_BASENAME=newlib-esp32
+  NEWLIB_URL_BASE=https://github.com/espressif/newlib-esp32/archive
+  NEWLIB_TARBALL=$(NEWLIB_VERSION).tar.gz
+else
+  NEWLIB_VERSION=4.3.0.20230120

Review Comment:
    4.1.0  is the latest version of newlib-esp32 I can find.
   I guess 4.3.0 is too new to start adaptation in Espressif.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org