[jira] Commented: (OFBIZ-2790) Payment totals in Accounting

["Sumit Pandit (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746849#action_12746849 ] 

Sumit Pandit commented on OFBIZ-2790:
-------------------------------------

Hi Ahmad, 

Thanks for your initiation and contribution, your idea is good and It should work. Though I am applying your patch after a long time, therefore there are some conflicts. To resolve this conflicts I would like you to upload the updated patch so that I can perform its functional testing. 

BTW, here are some quick comments on your work - 

1) FindPaymentTotals.groovy -> 
a) Please have a look at other groovy files in OFBiz and follow its convention, 
b) Avoid to use so many while spaces, unused lines in your code.
c) Write code in 4 spaces indentation of a block - for ex - 
instead of - 
+if(context.listIt != null) {
+totalAmount = 0.0;

use 
+if(context.listIt != null) {
+    totalAmount = 0.0;
d) In calculation of Amount (money calculation) use BigDecimal

2) 
a) Though "${groupName}${lastName},${firstName}" is used at some place in OFBiz - but I would recommend to use "${groupName}${lastName} ${firstName}" .
b) In implementation of a new code you have changed the formatting style of old code, Please keep the formatting of existing code untouched and change only that code which is required for your implementation. It helps us to find the difference in the code.

Please do above changes and upload the new patch. Your efforts are much appreciable.

> Payment totals in Accounting
> ----------------------------
>
>                 Key: OFBIZ-2790
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2790
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Ahmed Dini
>            Assignee: Anil K Patel
>             Fix For: SVN trunk
>
>         Attachments: paymentTotals.patch
>
>
> Under Accounting Manager --> Payments, Find Payments.  I thought it would be a handy improvement if I display a total of the Amount fields of all payments under the search result screen no matter what their status is. This new improvement might not makes sense when payment status are mixed i.e. The total of cancelled payments plus the total of received payments, but I thinks it might make sense if you want to filter the query. i.e if you want the total of all payments in NOT-PAID status by a particular party or customer. 
> Attached is patch which introduces a new groovy file namely  FindPaymentTotals.groovy and the modification of the existing PaymentForms.xml.
> NB. Since this is my first major improvement for Ofbiz project, I might have done things differently than most of the commiters or contributors expect. Please let me know if I break Ofbiz coding conventions, I am willing to improve the code. Otherwise the attached patch works fine and has passed all my tests

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.