You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "yaooqinn (via GitHub)" <gi...@apache.org> on 2023/02/08 01:44:44 UTC

[GitHub] [spark] yaooqinn commented on a diff in pull request #39929: [SPARK-42372][SQL] Improve performance of HiveGenericUDTF by making inputProjection instantiate once

yaooqinn commented on code in PR #39929:
URL: https://github.com/apache/spark/pull/39929#discussion_r1099539170


##########
sql/hive/benchmarks/HiveUDFBenchmark-results.txt:
##########
@@ -0,0 +1,7 @@
+OpenJDK 64-Bit Server VM 1.8.0_352-bre_2022_12_13_23_06-b00 on Mac OS X 13.1

Review Comment:
   +1 to @wangyum 's suggestion, as after this fix, the benchmarking is mostly evaluating hive udf execution



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org