You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/14 04:39:43 UTC
[GitHub] [pulsar] codelipenghui commented on a diff in pull request #17164: [improve][broker] Make cursor properties support modify single value concurrently.
codelipenghui commented on code in PR #17164:
URL: https://github.com/apache/pulsar/pull/17164#discussion_r970299664
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -324,24 +326,25 @@ public Map<String, String> getCursorProperties() {
return cursorProperties;
}
- @Override
- public CompletableFuture<Void> setCursorProperties(Map<String, String> cursorProperties) {
+ private CompletableFuture<Void> asyncReadAndUpdateCursorProperties(
+ final Function<Map<String, String>, Map<String, String>> updateFunction) {
CompletableFuture<Void> updateCursorPropertiesResult = new CompletableFuture<>();
ledger.getStore().asyncGetCursorInfo(ledger.getName(), name, new MetaStoreCallback<>() {
Review Comment:
Can we remove the get operation?
Instead, we can only update the local properties cache if we get a BadVersion exception
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -324,24 +326,25 @@ public Map<String, String> getCursorProperties() {
return cursorProperties;
}
- @Override
- public CompletableFuture<Void> setCursorProperties(Map<String, String> cursorProperties) {
+ private CompletableFuture<Void> asyncReadAndUpdateCursorProperties(
+ final Function<Map<String, String>, Map<String, String>> updateFunction) {
CompletableFuture<Void> updateCursorPropertiesResult = new CompletableFuture<>();
ledger.getStore().asyncGetCursorInfo(ledger.getName(), name, new MetaStoreCallback<>() {
@Override
public void operationComplete(ManagedCursorInfo info, Stat stat) {
+ final Map<String, String> newProperties = updateFunction.apply(ManagedCursorImpl.this.cursorProperties);
Review Comment:
Here might introduce a problem, the `ManagedCursorImpl.this.cursorProperties` is staled, but we will update the zookeeper with a new stat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org