You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Venkatakrishnan (JIRA)" <tu...@ws.apache.org> on 2006/10/02 20:18:28 UTC
[jira] Created: (TUSCANY-773) Fix Property Value Loading from
Component Definitions
Fix Property Value Loading from Component Definitions
-----------------------------------------------------
Key: TUSCANY-773
URL: http://issues.apache.org/jira/browse/TUSCANY-773
Project: Tuscany
Issue Type: Bug
Components: Java SCA Core
Affects Versions: Java-M2
Reporter: Venkatakrishnan
Currently property loading for application components does not work. There is NPE exception thrown when creating a property instance factory based on the property value defined in the Component Defn.
Also the property loading works only for simply types whose values can be represented as a simple xml text content.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Resolved: (TUSCANY-773) Fix Property Value Loading from
Component Definitions
Posted by "Venkatakrishnan (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Venkatakrishnan resolved TUSCANY-773.
-------------------------------------
Resolution: Fixed
This is resolved since property values get loaded from component defintions.
> Fix Property Value Loading from Component Definitions
> -----------------------------------------------------
>
> Key: TUSCANY-773
> URL: https://issues.apache.org/jira/browse/TUSCANY-773
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core
> Affects Versions: Java-M2
> Reporter: Venkatakrishnan
> Assigned To: Raymond Feng
> Fix For: Java-SCA-M3
>
> Attachments: rfeng.patch, Tuscany-kernel-core-02-Oct.diff, Tuscany-kernel-spi-02-Oct.diff, Tuscany-sca-kernel-core-03-Oct.diff, Tuscany-sca-kernel-spi-03-Oct.diff, Tuscany-spec-sca-02-Oct.diff, Tuscany-spec-sca-03-Oct.diff
>
>
> Currently property loading for application components does not work. There is NPE exception thrown when creating a property instance factory based on the property value defined in the Component Defn.
> Also the property loading works only for simply types whose values can be represented as a simple xml text content.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-773) Fix Property Value Loading from
Component Definitions
Posted by "Raymond Feng (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-773?page=comments#action_12439875 ]
Raymond Feng commented on TUSCANY-773:
--------------------------------------
> Hi Raymond,
>
> I have gone thro this and here are some questions / concerns: -
>
> 1) There is an assumption that the java type for the property is known which may not be true. All that might be known is the xml type. This will work if the componenttype loading is done thro introspection because the introspection processors set the JavaType of the property. But if you are loading thro the componentType file, the SimplePropertyObjectFactory could have problems. right?
>
Really, we shouldn't have dependencies on the JavaType which is just one of the databindings we support. I think "DataType" is more appropriate. The "SimplePropertyObjectFactory" simply does XML string to java simple types and it should be replaced by the generic-purpose PropertyObjectFactory which is based on the databinding framework. SimplePropertyObjectFactory can be used ror system components (I'm not sure if we have a chicken-egg problem to have component loader depend on databinding system services).
> 2) Talking about the componentType side file brings me to a 'blocker' that I experience. I have already mentioned about this earlier. It is about not being able to use the component type side file for java components. I have tried it several times and I end up with
>
> org.apache.tuscany.spi.loader.UnrecognizedElementException: {http://www.osoa.org/xmlns/sca/1.0}componentType {http://www.osoa.org/xmlns/sca/1.0}componentType]
>
> I want to know if this is a problem that I am alone experiencing. Should I raise a JIRA for this?
>
Can you post a test case? I checked the code and I found "ComponentTypeElementLoader" is registered and it should be able to load the componentType.
> 3) I see that the value object factory gets created for the PropertyValue in the ComponentLoader itself. Over here we transform the value xml to java objects. Having this function in the ComponentLoader will mean that this will be done for all implementations (java, javascript, rubyscript, groovy).
>
> Now for the scripts, where is the JavaType for the property available? All that might get mentioned is just about the xml type in the componentType file. This is again where the SimplePropertyObjectFactory could have problems (just about the same as what I have said above in point 1).
>
Again, I would assume the differences among different containers should be the databindings. We need to establish a contract so that the containers can nominate databindings for a property value. The PropertyValue is a neutual representation of the XML value of the property and it's subject to transformation.
> That is why I had put the function of converting the propertyvalues xml to java objects in the JavaComponentBuilder. This way the implementation builders just about get the xml document and it is upto them how they transform it to suit the underlying implementation (java, javascript, ruby,groovy). So in our Java Implementation, the builder simply transforms this to Java objects. Similarly I would expect the JS Builder to convert this xml data to JS objects (dono how do this though :)). Isn't this approach right - am I missing some point ?
I want to extract the commonalities. The builders should not be forced to do data transformation, but instead they should express what they want.
>
> 4) Is there something that you are doing about transforming complex xml content to java objects ? Can we not have the JavaPropertyFactory that I proposed, in place atleast upto the point when this is ready from the databinding framework ?
>
I suggest that you contribute a JavaBean databinding and some transformers which can deal with XML/JavaBeans. This way, we can use JavaBeans as properties. :-)
> Fix Property Value Loading from Component Definitions
> -----------------------------------------------------
>
> Key: TUSCANY-773
> URL: http://issues.apache.org/jira/browse/TUSCANY-773
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core
> Affects Versions: Java-M2
> Reporter: Venkatakrishnan
> Assigned To: Raymond Feng
> Attachments: rfeng.patch, Tuscany-kernel-core-02-Oct.diff, Tuscany-kernel-spi-02-Oct.diff, Tuscany-sca-kernel-core-03-Oct.diff, Tuscany-sca-kernel-spi-03-Oct.diff, Tuscany-spec-sca-02-Oct.diff, Tuscany-spec-sca-03-Oct.diff
>
>
> Currently property loading for application components does not work. There is NPE exception thrown when creating a property instance factory based on the property value defined in the Component Defn.
> Also the property loading works only for simply types whose values can be represented as a simple xml text content.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: [jira] Updated: (TUSCANY-773) Fix Property Value Loading from Component Definitions
Posted by Raymond Feng <en...@gmail.com>.
Hi,
You should be able to apply the patch using either "svn" command or
TortoiseSVN if you're on Windows.
Thanks,
Raymond
----- Original Message -----
From: "Raymond Feng (JIRA)" <tu...@ws.apache.org>
To: <tu...@ws.apache.org>
Sent: Monday, October 02, 2006 6:21 PM
Subject: [jira] Updated: (TUSCANY-773) Fix Property Value Loading from
Component Definitions
> [ http://issues.apache.org/jira/browse/TUSCANY-773?page=all ]
>
> Raymond Feng updated TUSCANY-773:
> ---------------------------------
>
> Attachment: rfeng.patch
>
> Hi, Venkata.
>
> I made some changes on top of your patch. I have attached the new one
> here.
>
> BTW, one class is missing in your path: JavaPropertyFactory. Can you add
> it?
>
> I'm also expecting more feautures such as XPath resolution against the
> "source" and DataBinding integration for the injection. Any plan?
>
> Thanks,
> Raymond
>
>
>
>> Fix Property Value Loading from Component Definitions
>> -----------------------------------------------------
>>
>> Key: TUSCANY-773
>> URL: http://issues.apache.org/jira/browse/TUSCANY-773
>> Project: Tuscany
>> Issue Type: Bug
>> Components: Java SCA Core
>> Affects Versions: Java-M2
>> Reporter: Venkatakrishnan
>> Attachments: rfeng.patch, Tuscany-kernel-core-02-Oct.diff,
>> Tuscany-kernel-spi-02-Oct.diff, Tuscany-spec-sca-02-Oct.diff
>>
>>
>> Currently property loading for application components does not work.
>> There is NPE exception thrown when creating a property instance factory
>> based on the property value defined in the Component Defn.
>> Also the property loading works only for simply types whose values can be
>> represented as a simple xml text content.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-773) Fix Property Value Loading from
Component Definitions
Posted by "Raymond Feng (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-773?page=all ]
Raymond Feng updated TUSCANY-773:
---------------------------------
Attachment: rfeng.patch
Hi, Venkata.
I made some changes on top of your patch. I have attached the new one here.
BTW, one class is missing in your path: JavaPropertyFactory. Can you add it?
I'm also expecting more feautures such as XPath resolution against the "source" and DataBinding integration for the injection. Any plan?
Thanks,
Raymond
> Fix Property Value Loading from Component Definitions
> -----------------------------------------------------
>
> Key: TUSCANY-773
> URL: http://issues.apache.org/jira/browse/TUSCANY-773
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core
> Affects Versions: Java-M2
> Reporter: Venkatakrishnan
> Attachments: rfeng.patch, Tuscany-kernel-core-02-Oct.diff, Tuscany-kernel-spi-02-Oct.diff, Tuscany-spec-sca-02-Oct.diff
>
>
> Currently property loading for application components does not work. There is NPE exception thrown when creating a property instance factory based on the property value defined in the Component Defn.
> Also the property loading works only for simply types whose values can be represented as a simple xml text content.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-773) Fix Property Value Loading from
Component Definitions
Posted by "Venkatakrishnan (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-773?page=all ]
Venkatakrishnan updated TUSCANY-773:
------------------------------------
Attachment: Tuscany-spec-sca-02-Oct.diff
Tuscany-kernel-spi-02-Oct.diff
Tuscany-kernel-core-02-Oct.diff
HI Raymond,
Here are the patches that do the following: -
- Load property values defined in application components copying default values wherever the value is absent and the default specified in the corresponding componentType.
- Enforces the 'override' options semantics to property defintions in scdls
- Enables the JavaCompnentBuilder to transform the property values from xml document form to appropriate java object instances and also creates the corresponding object factories.
I have successfully tested this for a simple component as this...
<component name="HelloWorldJavaReference">
<implementation.java class="helloworld.HelloWorldServiceImpl"/>
<property name="greeting">
Hullow
</property>
<property name="helloSayer">
<firstName>Tuscany</firstName>
<lastName>World</lastName>
</property>
</component>
Please review if the approach used is right and scalable.
Other Concerns
----------------------
*) I am unable to use the .componentType file. If I used one then I get the following exception:
org.apache.tuscany.spi.loader.UnrecognizedElementException: {http://www.osoa.org/xmlns/sca/1.0}componentType [{http://www.osoa.org/xmlns/sca/1.0}componentType]
Context stack trace: [application][HelloWorldJavaReference]
at org.apache.tuscany.core.loader.LoaderRegistryImpl.load(LoaderRegistryImpl.java:113)
Looks like there is problem if I mention JavaComponentType.class in the load method. I guess this because all othere containers have worked around this aspect.
Am I missing something here?
*) When I initially clipped the existing property value loading behaviour in the ComponentLoader, the system components could never get initialized. To go forward with this, I decided to address only application components. To this end, I retained the existing behaviour when the component is a SystemImplementation and changed it for other cases. I am not clear about the direction for this.
Thanks
- Venkat
> Fix Property Value Loading from Component Definitions
> -----------------------------------------------------
>
> Key: TUSCANY-773
> URL: http://issues.apache.org/jira/browse/TUSCANY-773
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core
> Affects Versions: Java-M2
> Reporter: Venkatakrishnan
> Attachments: Tuscany-kernel-core-02-Oct.diff, Tuscany-kernel-spi-02-Oct.diff, Tuscany-spec-sca-02-Oct.diff
>
>
> Currently property loading for application components does not work. There is NPE exception thrown when creating a property instance factory based on the property value defined in the Component Defn.
> Also the property loading works only for simply types whose values can be represented as a simple xml text content.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-773) Fix Property Value Loading from
Component Definitions
Posted by "Venkatakrishnan (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-773?page=comments#action_12439472 ]
Venkatakrishnan commented on TUSCANY-773:
-----------------------------------------
Hi Raymond, I am not able to apply your patch. Here is what I did.
I am working on eclipse and have all projects defined using mvn eclipse:eclipse, which I have then imported into the IDE.
When I try to apply your patch in say project 'tuscany-core', I end up with directories sca/kernel/core/... and no changes to the code. This is probably because you did a diff from sca. Could you please help me with some info on how I can apply this.
Thanks
- Venkat
> Fix Property Value Loading from Component Definitions
> -----------------------------------------------------
>
> Key: TUSCANY-773
> URL: http://issues.apache.org/jira/browse/TUSCANY-773
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core
> Affects Versions: Java-M2
> Reporter: Venkatakrishnan
> Attachments: rfeng.patch, Tuscany-kernel-core-02-Oct.diff, Tuscany-kernel-spi-02-Oct.diff, Tuscany-spec-sca-02-Oct.diff
>
>
> Currently property loading for application components does not work. There is NPE exception thrown when creating a property instance factory based on the property value defined in the Component Defn.
> Also the property loading works only for simply types whose values can be represented as a simple xml text content.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-773) Fix Property Value Loading from
Component Definitions
Posted by "ant elder (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-773?page=all ]
ant elder updated TUSCANY-773:
------------------------------
Fix Version/s: Java-M2
> Fix Property Value Loading from Component Definitions
> -----------------------------------------------------
>
> Key: TUSCANY-773
> URL: http://issues.apache.org/jira/browse/TUSCANY-773
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core
> Affects Versions: Java-M2
> Reporter: Venkatakrishnan
> Assigned To: Raymond Feng
> Fix For: Java-M2
>
> Attachments: rfeng.patch, Tuscany-kernel-core-02-Oct.diff, Tuscany-kernel-spi-02-Oct.diff, Tuscany-sca-kernel-core-03-Oct.diff, Tuscany-sca-kernel-spi-03-Oct.diff, Tuscany-spec-sca-02-Oct.diff, Tuscany-spec-sca-03-Oct.diff
>
>
> Currently property loading for application components does not work. There is NPE exception thrown when creating a property instance factory based on the property value defined in the Component Defn.
> Also the property loading works only for simply types whose values can be represented as a simple xml text content.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-773) Fix Property Value Loading from
Component Definitions
Posted by "Venkatakrishnan (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-773?page=comments#action_12439779 ]
Venkatakrishnan commented on TUSCANY-773:
-----------------------------------------
Hi Raymond,
I have gone thro this and here are some questions / concerns: -
1) There is an assumption that the java type for the property is known which may not be true. All that might be known is the xml type. This will work if the componenttype loading is done thro introspection because the introspection processors set the JavaType of the property. But if you are loading thro the componentType file, the SimplePropertyObjectFactory could have problems. right?
2) Talking about the componentType side file brings me to a 'blocker' that I experience. I have already mentioned about this earlier. It is about not being able to use the component type side file for java components. I have tried it several times and I end up with
org.apache.tuscany.spi.loader.UnrecognizedElementException: {http://www.osoa.org/xmlns/sca/1.0}componentType {http://www.osoa.org/xmlns/sca/1.0}componentType]
I want to know if this is a problem that I am alone experiencing. Should I raise a JIRA for this?
3) I see that the value object factory gets created for the PropertyValue in the ComponentLoader itself. Over here we transform the value xml to java objects. Having this function in the ComponentLoader will mean that this will be done for all implementations (java, javascript, rubyscript, groovy).
Now for the scripts, where is the JavaType for the property available? All that might get mentioned is just about the xml type in the componentType file. This is again where the SimplePropertyObjectFactory could have problems (just about the same as what I have said above in point 1).
That is why I had put the function of converting the propertyvalues xml to java objects in the JavaComponentBuilder. This way the implementation builders just about get the xml document and it is upto them how they transform it to suit the underlying implementation (java, javascript, ruby,groovy). So in our Java Implementation, the builder simply transforms this to Java objects. Similarly I would expect the JS Builder to convert this xml data to JS objects (dono how do this though :)). Isn't this approach right - am I missing some point ?
4) Is there something that you are doing about transforming complex xml content to java objects ? Can we not have the JavaPropertyFactory that I proposed, in place atleast upto the point when this is ready from the databinding framework ?
Let me know how we can go about this futher.
Thanks
- Venkat
> Fix Property Value Loading from Component Definitions
> -----------------------------------------------------
>
> Key: TUSCANY-773
> URL: http://issues.apache.org/jira/browse/TUSCANY-773
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core
> Affects Versions: Java-M2
> Reporter: Venkatakrishnan
> Assigned To: Raymond Feng
> Attachments: rfeng.patch, Tuscany-kernel-core-02-Oct.diff, Tuscany-kernel-spi-02-Oct.diff, Tuscany-sca-kernel-core-03-Oct.diff, Tuscany-sca-kernel-spi-03-Oct.diff, Tuscany-spec-sca-02-Oct.diff, Tuscany-spec-sca-03-Oct.diff
>
>
> Currently property loading for application components does not work. There is NPE exception thrown when creating a property instance factory based on the property value defined in the Component Defn.
> Also the property loading works only for simply types whose values can be represented as a simple xml text content.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-773) Fix Property Value Loading from
Component Definitions
Posted by "Jean-Sebastien Delfino (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Sebastien Delfino updated TUSCANY-773:
-------------------------------------------
Fix Version/s: (was: Java-M2)
Java-M3
> Fix Property Value Loading from Component Definitions
> -----------------------------------------------------
>
> Key: TUSCANY-773
> URL: https://issues.apache.org/jira/browse/TUSCANY-773
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core
> Affects Versions: Java-M2
> Reporter: Venkatakrishnan
> Assigned To: Raymond Feng
> Fix For: Java-M3
>
> Attachments: rfeng.patch, Tuscany-kernel-core-02-Oct.diff, Tuscany-kernel-spi-02-Oct.diff, Tuscany-sca-kernel-core-03-Oct.diff, Tuscany-sca-kernel-spi-03-Oct.diff, Tuscany-spec-sca-02-Oct.diff, Tuscany-spec-sca-03-Oct.diff
>
>
> Currently property loading for application components does not work. There is NPE exception thrown when creating a property instance factory based on the property value defined in the Component Defn.
> Also the property loading works only for simply types whose values can be represented as a simple xml text content.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-773) Fix Property Value Loading from
Component Definitions
Posted by "Venkatakrishnan (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-773?page=comments#action_12439743 ]
Venkatakrishnan commented on TUSCANY-773:
-----------------------------------------
Hi Raymond, thank you very much. I have updated my code with the commits and will now take a look and digest the changes you have made after which we shall get to the next steps.
Thanks for all the help
- Venkat
> Fix Property Value Loading from Component Definitions
> -----------------------------------------------------
>
> Key: TUSCANY-773
> URL: http://issues.apache.org/jira/browse/TUSCANY-773
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core
> Affects Versions: Java-M2
> Reporter: Venkatakrishnan
> Assigned To: Raymond Feng
> Attachments: rfeng.patch, Tuscany-kernel-core-02-Oct.diff, Tuscany-kernel-spi-02-Oct.diff, Tuscany-sca-kernel-core-03-Oct.diff, Tuscany-sca-kernel-spi-03-Oct.diff, Tuscany-spec-sca-02-Oct.diff, Tuscany-spec-sca-03-Oct.diff
>
>
> Currently property loading for application components does not work. There is NPE exception thrown when creating a property instance factory based on the property value defined in the Component Defn.
> Also the property loading works only for simply types whose values can be represented as a simple xml text content.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Assigned: (TUSCANY-773) Fix Property Value Loading from
Component Definitions
Posted by "Raymond Feng (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-773?page=all ]
Raymond Feng reassigned TUSCANY-773:
------------------------------------
Assignee: Raymond Feng
> Fix Property Value Loading from Component Definitions
> -----------------------------------------------------
>
> Key: TUSCANY-773
> URL: http://issues.apache.org/jira/browse/TUSCANY-773
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core
> Affects Versions: Java-M2
> Reporter: Venkatakrishnan
> Assigned To: Raymond Feng
> Attachments: rfeng.patch, Tuscany-kernel-core-02-Oct.diff, Tuscany-kernel-spi-02-Oct.diff, Tuscany-sca-kernel-core-03-Oct.diff, Tuscany-sca-kernel-spi-03-Oct.diff, Tuscany-spec-sca-02-Oct.diff, Tuscany-spec-sca-03-Oct.diff
>
>
> Currently property loading for application components does not work. There is NPE exception thrown when creating a property instance factory based on the property value defined in the Component Defn.
> Also the property loading works only for simply types whose values can be represented as a simple xml text content.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-773) Fix Property Value Loading from
Component Definitions
Posted by "Raymond Feng (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-773?page=comments#action_12439737 ]
Raymond Feng commented on TUSCANY-773:
--------------------------------------
Hi, Venkat.
I made changes based on your latest patch.
1) The component loader will create a map of PropertyValue(s) for each Property in the componentType.
2) We load the value of the PropertyValue as a DOM Document. The value can be the content of the element, from the source XPath or file URI.
3) A PropertyValue will be created for a property that is not overrided by the component. The value is the default.
4) We attach a ValueFactory to each PropertyValue. The factory should be able to create the desired instance for a property value (basically it transforms the DOM into the target databinding.) I have added a SimplePropertyFactory which knows how to create java simple types. The PropertyFactory will use the databnding framework to do complexType conversions.
5) The component builder will provide the property databinding information for the component impl and then it can get the value factory for each PropertyValue to create the instances and use its own way to pass to the component impl.
I'll commit the changes as the base.
Thanks,
Raymond
> Fix Property Value Loading from Component Definitions
> -----------------------------------------------------
>
> Key: TUSCANY-773
> URL: http://issues.apache.org/jira/browse/TUSCANY-773
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core
> Affects Versions: Java-M2
> Reporter: Venkatakrishnan
> Assigned To: Raymond Feng
> Attachments: rfeng.patch, Tuscany-kernel-core-02-Oct.diff, Tuscany-kernel-spi-02-Oct.diff, Tuscany-sca-kernel-core-03-Oct.diff, Tuscany-sca-kernel-spi-03-Oct.diff, Tuscany-spec-sca-02-Oct.diff, Tuscany-spec-sca-03-Oct.diff
>
>
> Currently property loading for application components does not work. There is NPE exception thrown when creating a property instance factory based on the property value defined in the Component Defn.
> Also the property loading works only for simply types whose values can be represented as a simple xml text content.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-773) Fix Property Value Loading from
Component Definitions
Posted by "Venkatakrishnan (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-773?page=all ]
Venkatakrishnan updated TUSCANY-773:
------------------------------------
Attachment: Tuscany-sca-kernel-core-03-Oct.diff
Tuscany-sca-kernel-spi-03-Oct.diff
Tuscany-spec-sca-03-Oct.diff
Hi Raymond,
I have now included the missing file. I pulled down the latest revision and have created these patchs over it.
I have tested for the following component defn. I created a simple Java Bean called HelloSayer that has two string fields - firstName and lastName. Then I added this as a field in the component implementation and exposed it as a property (with annotations). And then here in this comp. defn. i configure those properties.
--------------------------------------------------------------------------------------------------------
<component name="HelloWorldJavaReference">
<implementation.java class="helloworld.HelloWorldServiceImpl"/>
<property name="greeting">
Hullow
</property>
<property name="helloSayer">
<firstName>Tuscany</firstName>
<lastName>World</lastName>
</property>
</component>
HelloSayer.java
----------------------
public class HelloSayer {
public String firstName = "";
public String lastName = "";
}
HelloWorldServiceImpl.java
-------------------------------------
public class HelloWorldServiceImpl implements HelloWorldService {
@Property
public String greeting = "Default hello";
@Property
public HelloSayer helloSayer = new HelloSayer();
public String sayHello(String s) {
return greeting + " " + s + " from " + helloSayer.firstName + " " + helloSayer.lastName;
}
}
--------------------------------------------------------------------------------------------------------
*) to the question on support for xpath thro the 'source' attribute, I would prefer to get into this after we have containers (javascript, ruby and maybe even groovy) work for properties that are specified as xml within the comp. defn. itself. Just want to have the basic functionality working across containers. I see that 'source' will not be stop show since the user will still be able to get a feel of property config. for components. Is my view right here ?
*) As for the 'databinding', well I am really interested in getting that onboard for this with your help :). Right now the xml document is transformed to a java object using reflection. Do we have a databinding transformer that does this more and in more scalable way? And if so how do we fit it here - mean the programming model to be used to exploit the databinding facility. This is going to be something we may need across containers albiet in different forms.
Thanks
- Venkat
> Fix Property Value Loading from Component Definitions
> -----------------------------------------------------
>
> Key: TUSCANY-773
> URL: http://issues.apache.org/jira/browse/TUSCANY-773
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core
> Affects Versions: Java-M2
> Reporter: Venkatakrishnan
> Attachments: rfeng.patch, Tuscany-kernel-core-02-Oct.diff, Tuscany-kernel-spi-02-Oct.diff, Tuscany-sca-kernel-core-03-Oct.diff, Tuscany-sca-kernel-spi-03-Oct.diff, Tuscany-spec-sca-02-Oct.diff, Tuscany-spec-sca-03-Oct.diff
>
>
> Currently property loading for application components does not work. There is NPE exception thrown when creating a property instance factory based on the property value defined in the Component Defn.
> Also the property loading works only for simply types whose values can be represented as a simple xml text content.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: [jira] Commented: (TUSCANY-773) Fix Property Value Loading from Component Definitions
Posted by Venkata Krishnan <fo...@gmail.com>.
Sure Jim. Will look that up.
Thanks
- Venkat
On 10/4/06, Jim Marino <jm...@myromatours.com> wrote:
>
> Venkat, do you also want to file a bug with the spec group on
> osoa.org so we can fix this in the Java spec?
>
> Jim
>
> On Oct 3, 2006, at 5:03 PM, Jim Marino wrote:
>
> > O.K. that's fine. I just noticed the patch file but didn't look
> > closely at what it was.
> >
> > Jim
> >
> > On Oct 3, 2006, at 3:09 PM, Raymond Feng wrote:
> >
> >> Hi, Jim.
> >>
> >> I think Venkat has proposed to change the @Property annotation to
> >> reflect the "override" attribute defined by the SCA spec to to be
> >> "may", "no" or "must". It's not a Tuscany extension to me.
> >>
> >> Thanks,
> >> Raymond
> >>
> >> ----- Original Message ----- From: "Jim Marino (JIRA)" <tuscany-
> >> dev@ws.apache.org>
> >> To: <tu...@ws.apache.org>
> >> Sent: Tuesday, October 03, 2006 12:22 PM
> >> Subject: [jira] Commented: (TUSCANY-773) Fix Property Value
> >> Loading from Component Definitions
> >>
> >>
> >>> [ http://issues.apache.org/jira/browse/TUSCANY-773?
> >>> page=comments#action_12439633 ]
> >>>
> >>> Jim Marino commented on TUSCANY-773:
> >>> ------------------------------------
> >>>
> >>> I noticed the spec files changed. Venkat, could you explain why
> >>> this is necessary as I don't think we should be adding any
> >>> Tuscany extensions into the osoa namespace.
> >>>
> >>> Jim
> >>>
> >>>
> >>>> Fix Property Value Loading from Component Definitions
> >>>> -----------------------------------------------------
> >>>>
> >>>> Key: TUSCANY-773
> >>>> URL: http://issues.apache.org/jira/browse/
> >>>> TUSCANY-773
> >>>> Project: Tuscany
> >>>> Issue Type: Bug
> >>>> Components: Java SCA Core
> >>>> Affects Versions: Java-M2
> >>>> Reporter: Venkatakrishnan
> >>>> Attachments: rfeng.patch, Tuscany-kernel-core-02-
> >>>> Oct.diff, Tuscany-kernel-spi-02-Oct.diff, Tuscany-sca-kernel-
> >>>> core-03-Oct.diff, Tuscany-sca-kernel-spi-03-Oct.diff, Tuscany-
> >>>> spec-sca-02-Oct.diff, Tuscany-spec-sca-03-Oct.diff
> >>>>
> >>>>
> >>>> Currently property loading for application components does not
> >>>> work. There is NPE exception thrown when creating a property
> >>>> instance factory based on the property value defined in the
> >>>> Component Defn.
> >>>> Also the property loading works only for simply types whose
> >>>> values can be represented as a simple xml text content.
> >>>
> >>> --
> >>> This message is automatically generated by JIRA.
> >>> -
> >>> If you think it was sent incorrectly contact one of the
> >>> administrators: http://issues.apache.org/jira/secure/
> >>> Administrators.jspa
> >>> -
> >>> For more information on JIRA, see: http://www.atlassian.com/
> >>> software/jira
> >>>
> >>>
> >>>
> >>> --------------------------------------------------------------------
> >>> -
> >>> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> >>> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> >> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
> >>
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> > For additional commands, e-mail: tuscany-dev-help@ws.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
>
Re: [jira] Commented: (TUSCANY-773) Fix Property Value Loading from Component Definitions
Posted by Jim Marino <jm...@myromatours.com>.
Venkat, do you also want to file a bug with the spec group on
osoa.org so we can fix this in the Java spec?
Jim
On Oct 3, 2006, at 5:03 PM, Jim Marino wrote:
> O.K. that's fine. I just noticed the patch file but didn't look
> closely at what it was.
>
> Jim
>
> On Oct 3, 2006, at 3:09 PM, Raymond Feng wrote:
>
>> Hi, Jim.
>>
>> I think Venkat has proposed to change the @Property annotation to
>> reflect the "override" attribute defined by the SCA spec to to be
>> "may", "no" or "must". It's not a Tuscany extension to me.
>>
>> Thanks,
>> Raymond
>>
>> ----- Original Message ----- From: "Jim Marino (JIRA)" <tuscany-
>> dev@ws.apache.org>
>> To: <tu...@ws.apache.org>
>> Sent: Tuesday, October 03, 2006 12:22 PM
>> Subject: [jira] Commented: (TUSCANY-773) Fix Property Value
>> Loading from Component Definitions
>>
>>
>>> [ http://issues.apache.org/jira/browse/TUSCANY-773?
>>> page=comments#action_12439633 ]
>>>
>>> Jim Marino commented on TUSCANY-773:
>>> ------------------------------------
>>>
>>> I noticed the spec files changed. Venkat, could you explain why
>>> this is necessary as I don't think we should be adding any
>>> Tuscany extensions into the osoa namespace.
>>>
>>> Jim
>>>
>>>
>>>> Fix Property Value Loading from Component Definitions
>>>> -----------------------------------------------------
>>>>
>>>> Key: TUSCANY-773
>>>> URL: http://issues.apache.org/jira/browse/
>>>> TUSCANY-773
>>>> Project: Tuscany
>>>> Issue Type: Bug
>>>> Components: Java SCA Core
>>>> Affects Versions: Java-M2
>>>> Reporter: Venkatakrishnan
>>>> Attachments: rfeng.patch, Tuscany-kernel-core-02-
>>>> Oct.diff, Tuscany-kernel-spi-02-Oct.diff, Tuscany-sca-kernel-
>>>> core-03-Oct.diff, Tuscany-sca-kernel-spi-03-Oct.diff, Tuscany-
>>>> spec-sca-02-Oct.diff, Tuscany-spec-sca-03-Oct.diff
>>>>
>>>>
>>>> Currently property loading for application components does not
>>>> work. There is NPE exception thrown when creating a property
>>>> instance factory based on the property value defined in the
>>>> Component Defn.
>>>> Also the property loading works only for simply types whose
>>>> values can be represented as a simple xml text content.
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> If you think it was sent incorrectly contact one of the
>>> administrators: http://issues.apache.org/jira/secure/
>>> Administrators.jspa
>>> -
>>> For more information on JIRA, see: http://www.atlassian.com/
>>> software/jira
>>>
>>>
>>>
>>> --------------------------------------------------------------------
>>> -
>>> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
>>> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
>> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: [jira] Commented: (TUSCANY-773) Fix Property Value Loading from Component Definitions
Posted by Jim Marino <jm...@myromatours.com>.
O.K. that's fine. I just noticed the patch file but didn't look
closely at what it was.
Jim
On Oct 3, 2006, at 3:09 PM, Raymond Feng wrote:
> Hi, Jim.
>
> I think Venkat has proposed to change the @Property annotation to
> reflect the "override" attribute defined by the SCA spec to to be
> "may", "no" or "must". It's not a Tuscany extension to me.
>
> Thanks,
> Raymond
>
> ----- Original Message ----- From: "Jim Marino (JIRA)" <tuscany-
> dev@ws.apache.org>
> To: <tu...@ws.apache.org>
> Sent: Tuesday, October 03, 2006 12:22 PM
> Subject: [jira] Commented: (TUSCANY-773) Fix Property Value Loading
> from Component Definitions
>
>
>> [ http://issues.apache.org/jira/browse/TUSCANY-773?
>> page=comments#action_12439633 ]
>>
>> Jim Marino commented on TUSCANY-773:
>> ------------------------------------
>>
>> I noticed the spec files changed. Venkat, could you explain why
>> this is necessary as I don't think we should be adding any Tuscany
>> extensions into the osoa namespace.
>>
>> Jim
>>
>>
>>> Fix Property Value Loading from Component Definitions
>>> -----------------------------------------------------
>>>
>>> Key: TUSCANY-773
>>> URL: http://issues.apache.org/jira/browse/
>>> TUSCANY-773
>>> Project: Tuscany
>>> Issue Type: Bug
>>> Components: Java SCA Core
>>> Affects Versions: Java-M2
>>> Reporter: Venkatakrishnan
>>> Attachments: rfeng.patch, Tuscany-kernel-core-02-
>>> Oct.diff, Tuscany-kernel-spi-02-Oct.diff, Tuscany-sca-kernel-
>>> core-03-Oct.diff, Tuscany-sca-kernel-spi-03-Oct.diff, Tuscany-
>>> spec-sca-02-Oct.diff, Tuscany-spec-sca-03-Oct.diff
>>>
>>>
>>> Currently property loading for application components does not
>>> work. There is NPE exception thrown when creating a property
>>> instance factory based on the property value defined in the
>>> Component Defn.
>>> Also the property loading works only for simply types whose
>>> values can be represented as a simple xml text content.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> If you think it was sent incorrectly contact one of the
>> administrators: http://issues.apache.org/jira/secure/
>> Administrators.jspa
>> -
>> For more information on JIRA, see: http://www.atlassian.com/
>> software/jira
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
>> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: [jira] Commented: (TUSCANY-773) Fix Property Value Loading from Component Definitions
Posted by Raymond Feng <en...@gmail.com>.
Hi, Jim.
I think Venkat has proposed to change the @Property annotation to reflect
the "override" attribute defined by the SCA spec to to be "may", "no" or
"must". It's not a Tuscany extension to me.
Thanks,
Raymond
----- Original Message -----
From: "Jim Marino (JIRA)" <tu...@ws.apache.org>
To: <tu...@ws.apache.org>
Sent: Tuesday, October 03, 2006 12:22 PM
Subject: [jira] Commented: (TUSCANY-773) Fix Property Value Loading from
Component Definitions
> [
> http://issues.apache.org/jira/browse/TUSCANY-773?page=comments#action_12439633 ]
>
> Jim Marino commented on TUSCANY-773:
> ------------------------------------
>
> I noticed the spec files changed. Venkat, could you explain why this is
> necessary as I don't think we should be adding any Tuscany extensions into
> the osoa namespace.
>
> Jim
>
>
>> Fix Property Value Loading from Component Definitions
>> -----------------------------------------------------
>>
>> Key: TUSCANY-773
>> URL: http://issues.apache.org/jira/browse/TUSCANY-773
>> Project: Tuscany
>> Issue Type: Bug
>> Components: Java SCA Core
>> Affects Versions: Java-M2
>> Reporter: Venkatakrishnan
>> Attachments: rfeng.patch, Tuscany-kernel-core-02-Oct.diff,
>> Tuscany-kernel-spi-02-Oct.diff, Tuscany-sca-kernel-core-03-Oct.diff,
>> Tuscany-sca-kernel-spi-03-Oct.diff, Tuscany-spec-sca-02-Oct.diff,
>> Tuscany-spec-sca-03-Oct.diff
>>
>>
>> Currently property loading for application components does not work.
>> There is NPE exception thrown when creating a property instance factory
>> based on the property value defined in the Component Defn.
>> Also the property loading works only for simply types whose values can be
>> represented as a simple xml text content.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-773) Fix Property Value Loading from
Component Definitions
Posted by "Jim Marino (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-773?page=comments#action_12439633 ]
Jim Marino commented on TUSCANY-773:
------------------------------------
I noticed the spec files changed. Venkat, could you explain why this is necessary as I don't think we should be adding any Tuscany extensions into the osoa namespace.
Jim
> Fix Property Value Loading from Component Definitions
> -----------------------------------------------------
>
> Key: TUSCANY-773
> URL: http://issues.apache.org/jira/browse/TUSCANY-773
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Core
> Affects Versions: Java-M2
> Reporter: Venkatakrishnan
> Attachments: rfeng.patch, Tuscany-kernel-core-02-Oct.diff, Tuscany-kernel-spi-02-Oct.diff, Tuscany-sca-kernel-core-03-Oct.diff, Tuscany-sca-kernel-spi-03-Oct.diff, Tuscany-spec-sca-02-Oct.diff, Tuscany-spec-sca-03-Oct.diff
>
>
> Currently property loading for application components does not work. There is NPE exception thrown when creating a property instance factory based on the property value defined in the Component Defn.
> Also the property loading works only for simply types whose values can be represented as a simple xml text content.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org