You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by BJangir <gi...@git.apache.org> on 2018/02/11 19:37:31 UTC
[GitHub] carbondata pull request #1971: [CARBONDATA-2161]Compacted Segment of Streami...
GitHub user BJangir opened a pull request:
https://github.com/apache/carbondata/pull/1971
[CARBONDATA-2161]Compacted Segment of Streaming Table should update m…
Problem statement:-
When Handoff is trigger , ROW file format will be converted into COLUMNAR and that segment status will be updated as "Compacted". But "Merged TO" column is not updated.
Solution :- Along with Segment Status to "Compaction ",MergeTo Coloumn also will be updated which will tell that this Segment of Row File format is compacted /Converted to which Segment .
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
NO
- [ ] Any backward compatibility impacted?
NO
- [ ] Document update required?
NO
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
New Testcase is added
- How it is tested? Please attach test report.
TestCase written
- Is it a performance related change? Please attach the performance test report.
NA
- Any additional information to help reviewers in testing this change.
NA
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BJangir/incubator-carbondata CARBONDATA-2161
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1971.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1971
----
commit f757d93e06c74fb3d61e292d93ec93afcc4cb453
Author: BJangir <ba...@...>
Date: 2018-02-11T19:32:30Z
[CARBONDATA-2161]Compacted Segment of Streaming Table should update mergeTo column
----
---
[GitHub] carbondata issue #1971: [CARBONDATA-2161]Compacted Segment of Streaming Tabl...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1971
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3508/
---
[GitHub] carbondata issue #1971: [CARBONDATA-2161]Compacted Segment of Streaming Tabl...
Posted by QiangCai <gi...@git.apache.org>.
Github user QiangCai commented on the issue:
https://github.com/apache/carbondata/pull/1971
LGTM
---
[GitHub] carbondata issue #1971: [CARBONDATA-2161]Compacted Segment of Streaming Tabl...
Posted by BJangir <gi...@git.apache.org>.
Github user BJangir commented on the issue:
https://github.com/apache/carbondata/pull/1971
retest sdv please
---
[GitHub] carbondata pull request #1971: [CARBONDATA-2161]Compacted Segment of Streami...
Posted by QiangCai <gi...@git.apache.org>.
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1971#discussion_r167463294
--- Diff: integration/spark2/src/test/scala/org/apache/spark/carbondata/TestStreamingTableOperation.scala ---
@@ -698,6 +702,35 @@ class TestStreamingTableOperation extends QueryTest with BeforeAndAfterAll {
assertResult("The table has 'preaggregate' DataMap, it doesn't support streaming")(msg.getMessage)
}
+ test ("handoff segment to update mergedto segment value") {
--- End diff --
suggest merging this test case into test case "auto hand off, close and reopen streaming table"
because streaming ingestion will take more time.
---
[GitHub] carbondata issue #1971: [CARBONDATA-2161]Compacted Segment of Streaming Tabl...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1971
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2465/
---
[GitHub] carbondata issue #1971: [CARBONDATA-2161]Compacted Segment of Streaming Tabl...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1971
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3527/
---
[GitHub] carbondata pull request #1971: [CARBONDATA-2161]Compacted Segment of Streami...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1971
---
[GitHub] carbondata issue #1971: [CARBONDATA-2161]Compacted Segment of Streaming Tabl...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1971
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2486/
---
[GitHub] carbondata issue #1971: [CARBONDATA-2161]Compacted Segment of Streaming Tabl...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1971
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3726/
---
[GitHub] carbondata issue #1971: [CARBONDATA-2161]Compacted Segment of Streaming Tabl...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1971
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3537/
---
[GitHub] carbondata issue #1971: [CARBONDATA-2161]Compacted Segment of Streaming Tabl...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1971
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3705/
---
[GitHub] carbondata issue #1971: [CARBONDATA-2161]Compacted Segment of Streaming Tabl...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1971
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3523/
---
[GitHub] carbondata issue #1971: [CARBONDATA-2161]Compacted Segment of Streaming Tabl...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1971
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2482/
---
[GitHub] carbondata issue #1971: [CARBONDATA-2161]Compacted Segment of Streaming Tabl...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1971
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3722/
---