[GitHub] [doris] morningman commented on a diff in pull request #16117: [Fix](Oracle External Table) fix that oracle external table can not insert batch values

[GitBox <gi...@apache.org>]

morningman commented on code in PR #16117:
URL: https://github.com/apache/doris/pull/16117#discussion_r1082297783


##########
be/src/vec/exec/scan/new_jdbc_scanner.cpp:
##########
@@ -163,6 +164,13 @@ Status NewJdbcScanner::_get_block_impl(RuntimeState* state, Block* block, bool*
 Status NewJdbcScanner::close(RuntimeState* state) {
     RETURN_IF_ERROR(VScanner::close(state));
     RETURN_IF_ERROR(_jdbc_connector->close());
+    JdbcConnector::JdbcStatistic& jdbc_statistic = _jdbc_connector->get_jdbc_statistic();

Review Comment:
   Better not update counter when close().
   Because close() may be called after query is done, so FE will not receive these metrics.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org