You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Christopher Schultz <ch...@christopherschultz.net> on 2021/07/05 15:16:44 UTC
Re: [VOTE] Release Apache Tomcat 8.5.69
All,
On 6/29/21 17:03, Christopher Schultz wrote:
> The proposed Apache Tomcat 8.5.69 release is now available for voting.
>
> The notable changes compared to the 8.5.68 release are:
>
> - Re-work the HTTP/2 overhead protection to reduce the likelihood of
> false positives. Note that the default overheadCountFactor has changed
> from 1 to 10 and that the useful range is now 0 to ~20.
>
> - Fix regressions in JSP compilation in the previous release.
>
> - Improve HTTP header parsing to ignore empty elements in 1#token
> values, as per RFC 7230 section 7.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat-8.5.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.69/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1322/
>
> The tag is:
> https://github.com/apache/tomcat/tree/8.5.69
> a17eaf7de9aa166dea03a5bc3bb4f1915176a3c8
>
> The proposed 8.5.69 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 8.5.69
+0 for release
Works with a vanilla servlet-style application in development environment.
I'm a little concerned about these two tests which failed:
* org.apache.catalina.filters.TestExpiresFilter.NIO.txt
* org.apache.coyote.http2.TestStreamProcessor.NIO.txt
However, none of the other voters reported any unit-test errors, so I
will vote +0 due to the importance of getting the h2 and JSP fixes out.
Details:
* Environment
* Java (build): openjdk version "1.8.0_292" OpenJDK Runtime
Environment (build 1.8.0_292-8u292-b10-0+deb9u1-b10) OpenJDK 64-Bit
Server VM (build 25.292-b10, mixed mode)
* Java (test): openjdk version "1.8.0_292" OpenJDK Runtime
Environment (build 1.8.0_292-8u292-b10-0+deb9u1-b10) OpenJDK 64-Bit
Server VM (build 25.292-b10, mixed mode)
* OS: Linux 4.19.0-16-amd64 x86_64
* cc: cc (Debian 8.3.0-6) 8.3.0
* make: GNU Make 4.2.1
* OpenSSL: OpenSSL 1.1.1 11 Sep 2018
* APR: 1.6.5
*
* Valid SHA-512 signature for apache-tomcat-8.5.69.zip
* Valid GPG signature for apache-tomcat-8.5.69.zip
* Valid SHA-512 signature for apache-tomcat-8.5.69.tar.gz
* Valid GPG signature for apache-tomcat-8.5.69.tar.gz
* Valid SHA-512 signature for apache-tomcat-8.5.69.exe
* Valid GPG signature for apache-tomcat-8.5.69.exe
* Valid Windows Digital Signature for apache-tomcat-8.5.69.exe
* Valid SHA512 signature for apache-tomcat-8.5.69-src.zip
* Valid GPG signature for apache-tomcat-8.5.69-src.zip
* Valid SHA512 signature for apache-tomcat-8.5.69-src.tar.gz
* Valid GPG signature for apache-tomcat-8.5.69-src.tar.gz
*
* Binary Zip and tarball: Same
* Source Zip and tarball: Same
*
* Building dependencies returned: 0
* tcnative builds cleanly
* Tomcat builds cleanly
* Junit Tests: FAILED
*
* Tests that failed:
* org.apache.catalina.filters.TestExpiresFilter.APR.txt
* org.apache.catalina.filters.TestExpiresFilter.NIO.txt
* org.apache.catalina.filters.TestExpiresFilter.NIO2.txt
* org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.APR.txt
* org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO.txt
* org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO2.txt
* org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.APR.txt
* org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO.txt
*
org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO2.txt
* org.apache.catalina.tribes.group.TestGroupChannelStartStop.APR.txt
* org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO.txt
* org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO2.txt
*
org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.APR.txt
*
org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO.txt
*
org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO2.txt
* org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.APR.txt
* org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO.txt
*
org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO2.txt
*
org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.APR.txt
*
org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO.txt
*
org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO2.txt
* org.apache.coyote.http2.TestStreamProcessor.APR.txt
* org.apache.coyote.http2.TestStreamProcessor.NIO.txt
* org.apache.coyote.http2.TestStreamProcessor.NIO2.txt
* org.apache.tomcat.util.net.openssl.ciphers.TestCipher.APR.txt
* org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO.txt
* org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO2.txt
*
org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.APR.txt
*
org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.NIO.txt
*
org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.NIO2.txt
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.69
Posted by Igal Sapir <is...@apache.org>.
Chris,
On Mon, Jul 5, 2021 at 8:16 AM Christopher Schultz <
chris@christopherschultz.net> wrote:
> All,
>
> On 6/29/21 17:03, Christopher Schultz wrote:
> > The proposed Apache Tomcat 8.5.69 release is now available for voting.
> >
> > The notable changes compared to the 8.5.68 release are:
> >
> > - Re-work the HTTP/2 overhead protection to reduce the likelihood of
> > false positives. Note that the default overheadCountFactor has changed
> > from 1 to 10 and that the useful range is now 0 to ~20.
> >
> > - Fix regressions in JSP compilation in the previous release.
> >
> > - Improve HTTP header parsing to ignore empty elements in 1#token
> > values, as per RFC 7230 section 7.
> >
> > Along with lots of other bug fixes and improvements.
> >
> > For full details, see the changelog:
> > https://ci.apache.org/projects/tomcat/tomcat-8.5.x/docs/changelog.html
> >
> > It can be obtained from:
> > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.69/
> >
> > The Maven staging repo is:
> > https://repository.apache.org/content/repositories/orgapachetomcat-1322/
> >
> > The tag is:
> > https://github.com/apache/tomcat/tree/8.5.69
> > a17eaf7de9aa166dea03a5bc3bb4f1915176a3c8
> >
> > The proposed 8.5.69 release is:
> > [ ] Broken - do not release
> > [ ] Stable - go ahead and release as 8.5.69
>
> +0 for release
>
> Works with a vanilla servlet-style application in development environment.
>
> I'm a little concerned about these two tests which failed:
>
> * org.apache.catalina.filters.TestExpiresFilter.NIO.txt
> * org.apache.coyote.http2.TestStreamProcessor.NIO.txt
>
> However, none of the other voters reported any unit-test errors, so I
> will vote +0 due to the importance of getting the h2 and JSP fixes out.
>
Right, all of the unit tests passed for me and my exclusion list does not
cover those but I have "Relax Timing" on which may or may not play a role
with those tests (I didn't check). These are the settings I have for unit
tests:
test.exclude=org/apache/catalina/tribes/group/Test*,org/apache/catalina/tribes/group/interceptors/Test*
test.relaxTiming=true
HTH,
Igal
>
> Details:
>
> * Environment
> * Java (build): openjdk version "1.8.0_292" OpenJDK Runtime
> Environment (build 1.8.0_292-8u292-b10-0+deb9u1-b10) OpenJDK 64-Bit
> Server VM (build 25.292-b10, mixed mode)
> * Java (test): openjdk version "1.8.0_292" OpenJDK Runtime
> Environment (build 1.8.0_292-8u292-b10-0+deb9u1-b10) OpenJDK 64-Bit
> Server VM (build 25.292-b10, mixed mode)
> * OS: Linux 4.19.0-16-amd64 x86_64
> * cc: cc (Debian 8.3.0-6) 8.3.0
> * make: GNU Make 4.2.1
> * OpenSSL: OpenSSL 1.1.1 11 Sep 2018
> * APR: 1.6.5
> *
> * Valid SHA-512 signature for apache-tomcat-8.5.69.zip
> * Valid GPG signature for apache-tomcat-8.5.69.zip
> * Valid SHA-512 signature for apache-tomcat-8.5.69.tar.gz
> * Valid GPG signature for apache-tomcat-8.5.69.tar.gz
> * Valid SHA-512 signature for apache-tomcat-8.5.69.exe
> * Valid GPG signature for apache-tomcat-8.5.69.exe
> * Valid Windows Digital Signature for apache-tomcat-8.5.69.exe
> * Valid SHA512 signature for apache-tomcat-8.5.69-src.zip
> * Valid GPG signature for apache-tomcat-8.5.69-src.zip
> * Valid SHA512 signature for apache-tomcat-8.5.69-src.tar.gz
> * Valid GPG signature for apache-tomcat-8.5.69-src.tar.gz
> *
> * Binary Zip and tarball: Same
> * Source Zip and tarball: Same
> *
> * Building dependencies returned: 0
> * tcnative builds cleanly
> * Tomcat builds cleanly
> * Junit Tests: FAILED
> *
> * Tests that failed:
> * org.apache.catalina.filters.TestExpiresFilter.APR.txt
> * org.apache.catalina.filters.TestExpiresFilter.NIO.txt
> * org.apache.catalina.filters.TestExpiresFilter.NIO2.txt
> * org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.APR.txt
> * org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO.txt
> * org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO2.txt
> *
> org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.APR.txt
> *
> org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO.txt
> *
> org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO2.txt
> * org.apache.catalina.tribes.group.TestGroupChannelStartStop.APR.txt
> * org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO.txt
> * org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO2.txt
> *
>
> org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.APR.txt
> *
>
> org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO.txt
> *
>
> org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO2.txt
> *
> org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.APR.txt
> *
> org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO.txt
> *
> org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO2.txt
> *
>
> org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.APR.txt
> *
>
> org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO.txt
> *
>
> org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO2.txt
> * org.apache.coyote.http2.TestStreamProcessor.APR.txt
> * org.apache.coyote.http2.TestStreamProcessor.NIO.txt
> * org.apache.coyote.http2.TestStreamProcessor.NIO2.txt
> * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.APR.txt
> * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO.txt
> * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO2.txt
> *
> org.apache.tomcat.util.net
> .openssl.ciphers.TestOpenSSLCipherConfigurationParser.APR.txt
> *
> org.apache.tomcat.util.net
> .openssl.ciphers.TestOpenSSLCipherConfigurationParser.NIO.txt
> *
> org.apache.tomcat.util.net
> .openssl.ciphers.TestOpenSSLCipherConfigurationParser.NIO2.txt
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>